-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
possible excessive repainting on mouse motion due to errant semicolon #136
Comments
When in debug mode, e.g. "(123 paints)" is shown in the upper-right corner of the picture. In my perception, this gives instant clarity on a lot of repaint and speed issues which were previously elusive. E.g. it's now very easy to see the effect of keeping or removing the semicolon that is mentioned in issue #136.
behavior. Will live with it for a while to see if any missing repaint issues appear before closing the bug report.
Here are some missing repaint issues I have noticed. repaint() seems to be missing:
|
OK, I fixed those new repaint cases. Turns out it also allows the users to now see their color adjustments in real-time. Check it out:
|
Thanks! Regarding realtime color adjustment-- that's certainly worlds better, as long as the puzzle is small and/or antialiasing is off. |
…pears to improve" behavior. Will live with it for a while to see if any missing repaint issues appear before closing the bug report. (This cherry picks commit a73e56a from 'master` into 'melindas_changes_only'.)
…pears to improve" behavior. Will live with it for a while to see if any missing repaint issues appear before closing the bug report. (This cherry picks commit a73e56a from 'master` into 'melindas_changes_only'.)
OpenSDK javac warns about the semicolon after the "if" clause in MC4DView.java line 264:
It's possible that the semicolon shouldn't be there,
which would mean repaint() is getting called when it shouldn't be
(that is, on every mouse motion, even when the picture isn't changing).
I'm thinking that removing these excessive repaints could greatly improve
interaction/responsiveness, especially on bigger puzzles like the hypermegaminx,
in which every at-rest paint takes 2 seconds due to antialiasing.
The text was updated successfully, but these errors were encountered: