wrap siteDict access in try/catch #1651
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jhansen317 👋 Thanks for raising the issue. What version of music21 were you using? If you can reproduce on the latest, can you share the smallest MIDI file you have that reproduces the problem? I think we'd prefer to understand and fix the root cause rather than add a try. Thanks. |
|
closing for lack of discussion / tests / etc. Please feel free to reopen if this becomes active again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this has unintended side effects, but seems to work. The issue affected <10% of the midi files I am working with (i hesitate to put a number on it because I haven't really counted, but a minority.) I didn't see any open issues that looked germane, but I did not undertake an exhaustive search.