Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for using authenticated redis server #12

Closed
wants to merge 5 commits into from

Conversation

dfezzie
Copy link

@dfezzie dfezzie commented Nov 29, 2016

Used the BITMAPIST_REDIS_PASSWORD to provide support for an authenticated redis instance in the app config variables.

@frankV
Copy link
Member

frankV commented Nov 29, 2016

@dfezzie it looks like it failed on a PEP8 check. You can run the tests locally to make sure you're passing PEP8 and pyflakes.

I think @katie7r and I will want to write a test in for this before we merge - unless you want to tackle that?

@frankV
Copy link
Member

frankV commented Nov 29, 2016

Note that this will close #11

@dfezzie
Copy link
Author

dfezzie commented Nov 29, 2016

I can write a test for it, is there any specific way you want this done?

@coveralls
Copy link

coveralls commented Nov 29, 2016

Coverage Status

Coverage increased (+0.2%) to 69.17% when pulling 0a44a1f on dfezzie:master into cb7e702 on cuttlesoft:master.

@frankV
Copy link
Member

frankV commented Nov 29, 2016

We will have to update Travis so that it creates a redis instance with a password. But if you want to write the tests for it

@dfezzie
Copy link
Author

dfezzie commented Nov 29, 2016

Definitely! I'll get those done.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 69.17% when pulling fd31a1f on dfezzie:master into cb7e702 on cuttlesoft:master.

@frankV
Copy link
Member

frankV commented Apr 22, 2017

@dfezzie thanks for fixing the test, we still need an authenticated Redis server test to close this. Happy to help you with it if you need.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 69.17% when pulling bdf4ac1 on dfezzie:master into cb7e702 on cuttlesoft:master.

@coveralls
Copy link

coveralls commented Apr 24, 2017

Coverage Status

Coverage increased (+0.2%) to 69.17% when pulling d573dee on dfezzie:master into cb7e702 on cuttlesoft:master.

@dfezzie dfezzie closed this Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants