Apply comments

cvat-ai · Nov 27, 2020 · a804bf7 · a804bf7
1 parent e926973
commit a804bf7
Showing 1 changed file with 5 additions and 11 deletions.
diff --git a/tests/cypress/integration/actions_tasks_objects/case_20_objects_ordering_feature.js b/tests/cypress/integration/actions_tasks_objects/case_20_objects_ordering_feature.js
@@ -29,25 +29,19 @@ context('Objects ordering feature', () => {
         secondY: createRectangleShape2Points.secondY,
     };
 
-    function idAscent(arr) {
-        for (let i = 0; i < arr.length; i++) {
-            if (arr[i] > arr[i + 1]) {
-                return false;
-            }
-        }
-        return true;
-    }
-
     function checkSideBarItemOrdering(ordering) {
         let cvatObjectsSidebarStateItemIdList = [];
         cy.get('.cvat-objects-sidebar-state-item').then(($cvatObjectsSidebarStateItemId) => {
             for (let i = 0; i < $cvatObjectsSidebarStateItemId.length; i++) {
                 cvatObjectsSidebarStateItemIdList.push(Number($cvatObjectsSidebarStateItemId[i].id.match(/\d+$/)));
             }
+            const idAscent = cvatObjectsSidebarStateItemIdList.reduce((previousValue, currentValue) => {
+                return previousValue > currentValue ? false : true;
+            });
             if (ordering === 'ascent') {
-                expect(idAscent(cvatObjectsSidebarStateItemIdList)).to.be.true; //expected true to be true (ascent)
+                expect(idAscent).to.be.true; //expected true to be true (ascent)
             } else {
-                expect(idAscent(cvatObjectsSidebarStateItemIdList)).to.be.false; //expected false to be false (descent)
+                expect(idAscent).to.be.false; //expected false to be false (descent)
             }
         });
     }