Skip to content

Commit

Permalink
Added test for manifest filetype (#6951)
Browse files Browse the repository at this point in the history
<!-- Raise an issue to propose your change
(https://github.com/opencv/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution
guide](https://opencv.github.io/cvat/docs/contributing/). -->

<!-- Provide a general summary of your changes in the Title above -->

### Motivation and context
<!-- Why is this change required? What problem does it solve? If it
fixes an open
issue, please link to the issue here. Describe your changes in detail,
add
screenshots. -->
Test for #6890

### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->

### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [ ] I submit my changes into the `develop` branch
- [ ] I have added a description of my changes into the
[CHANGELOG](https://github.com/opencv/cvat/blob/develop/CHANGELOG.md)
file
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [ ] I have linked related issues (see [GitHub docs](

https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [ ] I have increased versions of npm packages if it is necessary

([cvat-canvas](https://github.com/opencv/cvat/tree/develop/cvat-canvas#versioning),

[cvat-core](https://github.com/opencv/cvat/tree/develop/cvat-core#versioning),

[cvat-data](https://github.com/opencv/cvat/tree/develop/cvat-data#versioning)
and

[cvat-ui](https://github.com/opencv/cvat/tree/develop/cvat-ui#versioning))

### License

- [ ] I submit _my code changes_ under the same [MIT License](
https://github.com/opencv/cvat/blob/develop/LICENSE) that covers the
project.
  Feel free to contact the maintainers if that's a concern.
  • Loading branch information
klakhov authored Oct 9, 2023
1 parent 4428e14 commit bcf1736
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ export default function ManifestsManager(props: Props): JSX.Element {
>
<Input
placeholder='manifest.jsonl'
className='cvat-cloud-storage-manifest-field'
onChange={(event) => onChangeManifestPath(event.target.value, idx)}
/>
</Form.Item>
Expand Down
21 changes: 17 additions & 4 deletions tests/cypress/e2e/actions_tasks3/case_105_cloud_storage.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,26 @@ context('Cloud storage.', () => {
cy.get($el).should('exist');
});
});
});

it('Check "Cloud Storage" manifest field.', () => {
// Check add/remove manifest file
cy.get('.cvat-add-manifest-button').should('be.visible').click();
cy.get('[placeholder="manifest.jsonl"]').should('exist').should('have.attr', 'value', '');
cy.get('[placeholder="manifest.jsonl"]').type(dummyData.manifest);
cy.get('[placeholder="manifest.jsonl"]').should('have.attr', 'value', dummyData.manifest);
cy.get('.cvat-cloud-storage-manifest-field').should('exist').should('have.attr', 'value', '');
cy.get('.cvat-cloud-storage-manifest-field').type(dummyData.manifest);
cy.get('.cvat-cloud-storage-manifest-field').should('have.attr', 'value', dummyData.manifest);
cy.get('[data-icon="delete"]').should('be.visible').click();
cy.get('.cvat-cloud-storage-manifest-field').should('not.exist');

// Check we can't add non-jsonl file
cy.get('.cvat-add-manifest-button').should('be.visible').click();
cy.get('.cvat-cloud-storage-manifest-field').type('manifest.json');
cy.get('.cvat-cloud-storage-manifest-field').should('have.attr', 'value', 'manifest.json');
cy.get('.cvat-cloud-storage-form').within(() => {
cy.contains('Manifest file must have .jsonl extension').should('exist');
});
cy.get('[data-icon="delete"]').should('be.visible').click();
cy.get('[placeholder="manifest.jsonl"]').should('not.exist');
cy.get('.cvat-cloud-storage-manifest-field').should('not.exist');
});

it('Check "AWS S3" provider fields.', () => {
Expand Down

0 comments on commit bcf1736

Please sign in to comment.