Skip to content

Commit

Permalink
Fixed issue: Uncaught TypeError: this.el.node.getScreenCTM() is null … (
Browse files Browse the repository at this point in the history
#4175)

* Fixed issue: Uncaught TypeError: this.el.node.getScreenCTM() is null in Firefox

* Updated version and changelog

* Fixed test
  • Loading branch information
Boris Sekachev authored Jan 14, 2022
1 parent b6f3b05 commit da82f4f
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Order in an annotation file(<https://github.com/openvinotoolkit/cvat/pull/4087>)
- Fixed task data upload progressbar (<https://github.com/openvinotoolkit/cvat/pull/4134>)
- Email in org invitations is case sensitive (<https://github.com/openvinotoolkit/cvat/pull/4153>)
- Uncaught TypeError: this.el.node.getScreenCTM() is null in Firefox (<https://github.com/openvinotoolkit/cvat/pull/4175>)
- Bug: canvas is busy when start playing, start resizing a shape and do not release the mouse cursor (<https://github.com/openvinotoolkit/cvat/pull/4151>)
- Fixed tus upload error over https (<https://github.com/openvinotoolkit/cvat/pull/4154>)

Expand Down
4 changes: 2 additions & 2 deletions cvat-canvas/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cvat-canvas/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "cvat-canvas",
"version": "2.12.1",
"version": "2.12.2",
"description": "Part of Computer Vision Annotation Tool which presents its canvas library",
"main": "src/canvas.ts",
"scripts": {
Expand Down
8 changes: 7 additions & 1 deletion cvat-canvas/src/typescript/canvasView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1947,6 +1947,8 @@ export class CanvasViewImpl implements CanvasView, Listener {
hideText();
(shape as any).on('remove.drag', (): void => {
this.mode = Mode.IDLE;
// disable internal drag events of SVG.js
window.dispatchEvent(new MouseEvent('mouseup'));
});
})
.on('dragend', (e: CustomEvent): void => {
Expand Down Expand Up @@ -2028,7 +2030,11 @@ export class CanvasViewImpl implements CanvasView, Listener {
if (state.shapeType === 'rectangle') {
shapeSizeElement = displayShapeSize(this.adoptedContent, this.adoptedText);
}
(shape as any).on('remove.resize', resizeFinally);
(shape as any).on('remove.resize', () => {
// disable internal resize events of SVG.js
window.dispatchEvent(new MouseEvent('mouseup'));
resizeFinally();
});
})
.on('resizing', (): void => {
resized = true;
Expand Down

0 comments on commit da82f4f

Please sign in to comment.