Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Image compression" definition mismatch #1900

Closed
2 tasks done
ilouzl opened this issue Jul 15, 2020 · 3 comments · Fixed by #1904
Closed
2 tasks done

"Image compression" definition mismatch #1900

ilouzl opened this issue Jul 15, 2020 · 3 comments · Fixed by #1904
Labels
Easy to fix The issue is easy to fix and probably it will be release in a next minor release

Comments

@ilouzl
Copy link
Contributor

ilouzl commented Jul 15, 2020

My actions before raising this issue

Mismatch between the definition of "Image quality" parameter in the Task creation page, and it's definition in the User's Guide.

Expected Behaviour

High "Image quality" parameter should yield low compression level - and vice versa.
Also, need to maintain consistency between the documentation and the actual parameter meaning.

Current Behaviour

In the User guide It's defined in the opposite way - Image Quality. Use this option to specify quality of uploaded images. The option helps to load high resolution datasets faster. Use the value from 1 (completely compressed images) to 95 (almost not compressed images)
In the Task page, the Image quality parameter tooltip displays Defines image compression level which may sound inverse to Image quality. - and in fact low value in this field yields high compression level <-> lower image quality.

Possible Solution

Either change the name of the parameter to

Context

Confusion when trying to lower image quality in order to achieve better streaming experience when dealing with high resolution videos.

Your Environment

  • Git hash commit (git log -1): 07de714
  • Docker version docker version (e.g. Docker 17.0.05): 19.03.12
  • Are you using Docker Swarm or Kubernetes? No
  • Operating System and version (e.g. Linux, Windows, MacOS): Ubuntu 18
  • Code example or link to GitHub repo or gist to reproduce problem:
  • Other diagnostic information / logs:
    Logs from `cvat` container

Next steps

You may join our Gitter channel for community support.

@azhavoro
Copy link
Contributor

@ilouzl thanks for the report!

@azhavoro azhavoro added documentation Documentation should be updated Easy to fix The issue is easy to fix and probably it will be release in a next minor release good first issue and removed documentation Documentation should be updated labels Jul 15, 2020
@nmanovic
Copy link
Contributor

@ilouzl , thanks for the issue. Do you think you can help us to prepare the PR?

@ilouzl
Copy link
Contributor Author

ilouzl commented Jul 15, 2020

Sure

bsekachev pushed a commit that referenced this issue Jul 15, 2020
* make intuitive and consistent definition of 'Image quality' parameter across Task creation context and documentation.

* updated changelog

Co-authored-by: Liron Ilouz <liron@tapwithus.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy to fix The issue is easy to fix and probably it will be release in a next minor release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants