Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating a task with the same attributes name within the same label. #3113

Closed
2 tasks done
dvkruchinin opened this issue Apr 21, 2021 · 2 comments · Fixed by #7890
Closed
2 tasks done

Creating a task with the same attributes name within the same label. #3113

dvkruchinin opened this issue Apr 21, 2021 · 2 comments · Fixed by #7890
Assignees
@bsekachev
Labels
bug Something isn't working Easy to fix The issue is easy to fix and probably it will be release in a next minor release good first issue Good for newcomers

Comments

@dvkruchinin
Copy link
Contributor

My actions before raising this issue

Expected Behaviour

Probably need to show a notification that can't create attributes with the same name.

Current Behaviour

Error with code 500

Possible Solution

Probably to add the appropriate notification.

Steps to Reproduce (for bugs)

  1. Start creating a task
  2. Add name, label with attributes with the same name (2 attributes are enough).
  3. Add image, press Submit.

Context

Your Environment

  • Git hash commit (git log -1): adbc74f
  • Docker version docker version (e.g. Docker 17.0.05): 20.10.5
  • Are you using Docker Swarm or Kubernetes? No
  • Operating System and version (e.g. Linux, Windows, MacOS): Windows 10
  • Code example or link to GitHub repo or gist to reproduce problem:
  • Other diagnostic information / logs:
    Logs from `cvat` container

Next steps

You may join our Gitter channel for community support.
@azhavoro azhavoro added bug Something isn't working Easy to fix The issue is easy to fix and probably it will be release in a next minor release enhancement New feature or request and removed bug Something isn't working labels May 18, 2021
@bsekachev bsekachev self-assigned this Jun 8, 2021
@nmanovic nmanovic added bug Something isn't working and removed enhancement New feature or request labels Nov 23, 2021
@bsekachev bsekachev mentioned this issue Jul 18, 2023
Merged
7 tasks
bsekachev added a commit that referenced this issue Jul 19, 2023
@bsekachev
Fixed default value for an attribute (RAW editor), refactored labels …
f861aef 
…editor (#6474)

<!-- Raise an issue to propose your change
(https://github.com/opencv/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution
guide](https://opencv.github.io/cvat/docs/contributing/). -->

<!-- Provide a general summary of your changes in the Title above -->

### Motivation and context
Resolved #6415
Related #3113 (need to fix server part and probably throw code 400, not
500)
Related #2927 (need to fix server)


![image](https://github.com/opencv/cvat/assets/40690378/016f9def-bd5f-4dcf-9a00-c6b75b0dd50f)


### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->

### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- [x] I have added a description of my changes into the
[CHANGELOG](https://github.com/opencv/cvat/blob/develop/CHANGELOG.md)
file
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [x] I have linked related issues (see [GitHub docs](

https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [x] I have increased versions of npm packages if it is necessary

([cvat-canvas](https://github.com/opencv/cvat/tree/develop/cvat-canvas#versioning),

[cvat-core](https://github.com/opencv/cvat/tree/develop/cvat-core#versioning),

[cvat-data](https://github.com/opencv/cvat/tree/develop/cvat-data#versioning)
and

[cvat-ui](https://github.com/opencv/cvat/tree/develop/cvat-ui#versioning))

### License

- [x] I submit _my code changes_ under the same [MIT License](
https://github.com/opencv/cvat/blob/develop/LICENSE) that covers the
project.
  Feel free to contact the maintainers if that's a concern.
mikhail-treskin pushed a commit to retailnext/cvat that referenced this issue Oct 25, 2023
@bsekachev @mikhail-treskin
Fixed default value for an attribute (RAW editor), refactored labels …
4ae1862 
…editor (cvat-ai#6474)

<!-- Raise an issue to propose your change
(https://github.com/opencv/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution
guide](https://opencv.github.io/cvat/docs/contributing/). -->

<!-- Provide a general summary of your changes in the Title above -->

### Motivation and context
Resolved cvat-ai#6415
Related cvat-ai#3113 (need to fix server part and probably throw code 400, not
500)
Related cvat-ai#2927 (need to fix server)


![image](https://github.com/opencv/cvat/assets/40690378/016f9def-bd5f-4dcf-9a00-c6b75b0dd50f)


### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->

### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- [x] I have added a description of my changes into the
[CHANGELOG](https://github.com/opencv/cvat/blob/develop/CHANGELOG.md)
file
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [x] I have linked related issues (see [GitHub docs](

https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [x] I have increased versions of npm packages if it is necessary

([cvat-canvas](https://github.com/opencv/cvat/tree/develop/cvat-canvas#versioning),

[cvat-core](https://github.com/opencv/cvat/tree/develop/cvat-core#versioning),

[cvat-data](https://github.com/opencv/cvat/tree/develop/cvat-data#versioning)
and

[cvat-ui](https://github.com/opencv/cvat/tree/develop/cvat-ui#versioning))

### License

- [x] I submit _my code changes_ under the same [MIT License](
https://github.com/opencv/cvat/blob/develop/LICENSE) that covers the
project.
  Feel free to contact the maintainers if that's a concern.
@bsekachev bsekachev added the good first issue Good for newcomers label Mar 11, 2024
@KrishavRajSingh
Copy link
Contributor

I think this issue is resolved.
image

If there is something left, I would like to work on this.

@KrishavRajSingh
Copy link
Contributor

I think i need to fix the server if duplicate values are coming. Right??

@KrishavRajSingh KrishavRajSingh mentioned this issue May 14, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsekachev bsekachev

Labels
bug Something isn't working Easy to fix The issue is easy to fix and probably it will be release in a next minor release good first issue Good for newcomers
Projects
Server and REST API
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed server for duplicate attribute names KrishavRajSingh/cvat
5 participants
@dvkruchinin @bsekachev @nmanovic @azhavoro @KrishavRajSingh