Add more environment variables to configure CVAT container #445

ppanczyk · 2019-05-08T14:35:06Z

Hello,
it would be nice to be able to configure database and Redis connections by environment variables. Currently hostnames (cvat_db and cvat_redis) are hardcoded (I see 'cvat_redis' not only in settings/production.py, but also in supervisord.conf). It would also be good to configure auth to Postgres and Redis this way.

I tried to run CVAT on Kubernetes and was stuck on this - I used modified Helm charts to deploy Postgres and Redis (I changed service names), however Helm complained that the underscore is not a valid character for a DNS name.

nmanovic · 2019-05-12T13:31:07Z

@ppanczyk , it is very specific request I'm not sure that we will be able to do that without your support. We don't try to run CVAT on Kubernetes at the moment. Thus it will be extremely difficult for us to test a solution for your use case. Could you please send us a PR and we will be happy to integrate it?

amiralipour · 2019-08-23T03:07:05Z

Hey I am having the same issue, It is about the two services that CVAT requires (cvat_db:5432) and (cvat_redis:6379). Kubernetes does not allow underscore (_) to be on the DNS names. Is there any way to change the default name of the services that CVAT container waits for before starting?
For instance can we make CVAT look for (cvat-db:5432) and (cvat-redis:6379) instead?

inealey · 2019-10-14T21:41:00Z

I am having the same issue.

Hey I am having the same issue, It is about the two services that CVAT requires (cvat_db:5432) and (cvat_redis:6379). Kubernetes does not allow underscore (_) to be on the DNS names. Is there any way to change the default name of the services that CVAT container waits for before starting?
For instance can we make CVAT look for (cvat-db:5432) and (cvat-redis:6379) instead?

@amiralipour have you found a workaround for this?

amiralipour · 2019-10-14T22:55:35Z

@inealey
I ended up creating my own docker images after modifying cvat/cvat/settings/production.py lines 14 and 16 from cvat_redis, cvat_db to cvat-redis, cvat-db respectively and deploying the same name services on the k8s cluster.

nmanovic · 2019-10-15T07:28:10Z

@amiralipour , could you please prepare a PR to improve CVAT?

valiantljk · 2019-10-18T20:55:19Z

@amiralipour could you share your steps in deploying cvat on k8s in more details, would be greatly appreciated.

Langhalsdino · 2019-11-28T11:18:14Z

I am looking to get CVAT running in my K8s cluster, too and facing a few issues regarding the front and back-end connection.

Specially the hardcoded url schemes during build are not ideal. Did anyone managed to dynamically insert backend address with env vars during runtime?

Why did you define:
cvat-ui/.env.production
REACT_APP_API_FULL_URL=${REACT_APP_API_PROTOCOL}://${REACT_APP_API_HOST}/api/v1
and use
cvat-ui/src/core.ts
cvat.config.backendAPI = `${protocol}://${host}:${port}/api/v1`;

nmanovic · 2019-11-28T11:26:00Z

@Langhalsdino , in case of docker-compose you can easily specify these environment variables in docker-compose.yml. I have no idea how to do that with K8s cluster.

Langhalsdino · 2019-11-28T11:28:55Z

The main challenge is that k8s is only delpoying pre build containers from a registry. Therefore the env need to be inserted during runtime of the nginx container and not during build.

nmanovic · 2019-11-28T11:31:20Z

@Langhalsdino , probably you can mount /etc/environment from host. It is just an idea.

valiantljk · 2020-01-07T00:01:41Z

any plan to support this?
I have to rebuilt the image every time when the host is changed

Langhalsdino · 2020-01-07T12:04:13Z

You don't need to rebuild the image every time just set other environment variables at runtime or the k8s YAML that describe the features.

The cvat-backend container has the following env that can be adjusted:

env:
- name: ALLOWED_HOSTS
  value: "my.fancy.domain.com"

Furthermore, the cvat-frontend has the following configurations:

env:
- name: REACT_APP_API_PROTOCOL
   value: "http"
- name: REACT_APP_API_HOST
   value: "My.fancy.domain.com"
- name: REACT_APP_API_PORT
  value: "8080"

Furthermore i adjusted cvat-ui/src/core.ts

const backendAPI = process.env.REACT_APP_API_FULL_URL;

I needed to do some modifications to cvat itself in order to get it working, which might introduce new bugs and disable features. If someone is interested in the changes and K8s YAML files feel free to 👍 and I will try to sort everything and share it :)

ofaz · 2020-02-13T13:58:56Z

@Langhalsdino I hate to hijack this issue - however I'm very interested in your modifications to facilitate K8s deployment.

Langhalsdino · 2020-02-13T14:31:30Z

@Langhalsdino I hate to hijack this issue - however I'm very interested in your modifications to facilitate K8s deployment.

I just changed the references to each container with regards to a environmental variable, that is set in the k8s deployment config.

cvat/settings/production.py:

for key in RQ_QUEUES:
    RQ_QUEUES[key]['HOST'] = os.getenv('CVAT_REDIS_HOST', 'cvat-redis')

CACHEOPS_REDIS['host'] = os.getenv('CVAT_REDIS_HOST', 'cvat-redis')

For the supervisord config i used the environmental variables too%(ENV_CVAT_REDIS_HOST)s

Form my current knowledge the other changes i made have been about fixing things like ffmpeg quality, ...

atemate · 2020-02-19T22:22:47Z

@Langhalsdino in my use-case cvat containers (cvat_db, cvat_redis, cvat, cvat_ui`) also run in environments with different hostnames. Didn't you need to expose the following hard-coded value as well?
https://github.com/opencv/cvat/blob/1a040a0608864fcc078565380c769a454f5a48c1/cvat/settings/production.py#L28

Langhalsdino · 2020-02-24T16:13:34Z

We do this with environmental variables that are mounted into the container by cvat itself.

e.g. here is one of our configure yamls:

apiVersion: extensions/v1beta1
kind: Deployment
metadata:
  name: cvat-backend
  namespace: production
  labels:
    app: cvat-app
    tier: backend
spec:
  replicas: 1
  strategy:
    type: Recreate
  selector:
    matchLabels:
      app: cvat-app
      tier: backend
  template:
    metadata:
      labels:
        app: cvat-app
        tier: backend
    spec:
      containers:
        - name: cvat-backend-app-container
          image: privat.registry.com/.../cvat/backend:latest
          imagePullPolicy: Always
          resources:
            requests:
              cpu: 10m
              memory: 100Mi
          env:
          - name: DJANGO_MODWSGI_EXTRA_ARGS
            value: ""
          - name: UI_PORT
            value: "80"
          - name: UI_HOST
            value: "cvat-frontend-service"
          - name: ALLOWED_HOSTS
            value: ".domain.com"
          - name: CVAT_REDIS_HOST
            value: "cvat-redis-service"
          - name: CVAT_DB_HOST
            value: "cvat-postgres-service"
          - name: CVAT_NAME
            valueFrom:
              secretKeyRef:
                name: cvat-postgres-secret
                key: POSTGRES_DB
          - name: CVAT_USER
            valueFrom:
              secretKeyRef:
                name: cvat-postgres-secret
                key: POSTGRES_USER
          - name: POSTGRES_PASSWORD
            valueFrom:
              secretKeyRef:
                name: cvat-postgres-secret
                key: POSTGRES_PASSWORD
          ports:
          - containerPort: 8080
          resources: {}
          volumeMounts:
          - mountPath: /home/django/data
            name: cvat-backend-data
            subPath: data
          - mountPath: /home/django/keys
            name: cvat-backend-data
            subPath: keys
          - mountPath: /home/django/logs
            name: cvat-backend-data
            subPath: logs
          - mountPath: /home/django/models
            name: cvat-backend-data
            subPath: models
      initContainers:
        - name: user-data-permission-fix
          image: busybox
          command: ["/bin/chmod", "-R", "777", "/home/django"]
          volumeMounts:
          - mountPath: /home/django/data
            name: cvat-backend-data
            subPath: data
          - mountPath: /home/django/keys
            name: cvat-backend-data
            subPath: keys
          - mountPath: /home/django/logs
            name: cvat-backend-data
            subPath: logs
          - mountPath: /home/django/models
            name: cvat-backend-data
            subPath: models
      volumes:
        - name: cvat-backend-data
          persistentVolumeClaim:
            claimName: cvat-backend-data

Our custom K8s resources consist of the following:

cvat-backend-deployment.yaml 
cvat-frontend-deployment.yaml 
cvat-frontend-service.yaml 
cvat-persistent-volume.yaml 
cvat-postgres-deployment.yaml 
cvat-postgres-persistent-volume.yaml
cvat-postgres-secret.yaml
cvat-postgres-service.yaml
cvat-redis-deployment.yaml
cvat-redis-service.yaml
cvat-service.yaml

Langhalsdino · 2020-02-24T16:16:16Z

I will try to publish useful K8s yml templates, as soon as public docker containers are available.

TaSeeMba · 2020-10-01T08:25:42Z

@Langhalsdino what changes are needed to enable the share path https://github.com/openvinotoolkit/cvat/blob/master/cvat/apps/documentation/installation.md#share-path using persistent volumes ? i am building a data ingestion pipeline from aws s3 that needs to push the bulk images into the CVAT directly

Langhalsdino · 2020-10-01T18:03:09Z

@Langhalsdino what changes are needed to enable the share path https://github.com/openvinotoolkit/cvat/blob/master/cvat/apps/documentation/installation.md#share-path using persistent volumes ? i am building a data ingestion pipeline from aws s3 that needs to push the bulk images into the CVAT directly

Since you shared that you are using the (PR k8s template)[https://github.com/apic-ai/cvat/tree/release-1.1.0/kubernetes-templates] template via email my suggestions are according to this (PR 1962)[https://github.com//pull/1962]

Since Kubernetes is managing a cluster, to my knowledge it is not possible to expose a host path on a machine to a pod directly.

I am not sure what you are trying to build exactly, but i think two approaches might be of interest to you:

Kubernetes Init Containers - K8s docu
Use case: add an init container to the deployment that syncs the files aws s3 sync src local_dest with the local directory.
-> Adding an init container to the 04_cvat_backend_deployment.yml is probably sufficient.
I did not try this, but something like this could solve the issue:

 initContainers::
      - name: kubectl-aws
        image: amazon/aws-cli
        # env/... -> Get your credentials inside the container
        command: [ "/bin/bash", "-c", "aws s3 sync s3://my-bucket/ /home/data/share" ]

Switch from a ReadWriteOnce persistent volume claim to a ReadWriteMany volume claim - K8s docu
Use case: have another deployment accessing the same volume that is handling the sync of the files .
Depending on your version of k8s, host, ... it could be as easy as changing the file 02_cvat_backend_storage.yml

accessModes:
    - ReadWriteOnce

to

accessModes:
    - ReadWriteMany

(Table containing support of access modes)[https://kubernetes.io/docs/concepts/storage/persistent-volumes/#access-modes]

Even though everything is subjective, i would say that the first approach is easier than the second.

Please share your experiences and share the way you choose to solve the issue.

jizg · 2020-10-11T10:41:42Z

@TaSeeMba @Langhalsdino I am also finding a way to config s3 compatible bucket as share path of CVAT. I found this https://github.com/IBM/dataset-lifecycle-framework project can be used to setup s3 bucket as a pvc, and mount to CVAT backend as share path. Brief steps are 1. install dataset-lifecycle-framework, 2. create a dataset with s3 bucket credentials and endpoint, and 3. configure cvat-backend-deployment.yml to use the dataset. YAML is something like:

  metadata:
  name: cvat-backend
  namespace: cvat
  labels:
    app: cvat-app
    tier: backend
    dataset.0.id: "cos-dataset"
    dataset.0.useas: "mount"
...
          - mountPath: /home/django/share
            name: "cos-dataset"
...
      volumes:
        - name: cvat-backend-data
          persistentVolumeClaim:
            claimName: cvat-backend-data
        - name: cos-dataset
          persistentVolumeClaim:
            claimName: cos-dataset

nmanovic assigned ppanczyk May 12, 2019

nmanovic added this to the Backlog milestone May 12, 2019

nmanovic added the enhancement New feature or request label May 12, 2019

nmanovic modified the milestones: Backlog, 1.0.0 - Release Oct 15, 2019

Langhalsdino mentioned this issue Nov 29, 2019

[WIP] Switch from ubuntu base docker image to debian #879

Closed

nmanovic modified the milestones: 1.0.0-release, Backlog May 23, 2020

rushtehrani mentioned this issue Jun 3, 2020

Add environment variables for Redis and Postgres hosts #1641

Merged

8 tasks

nmanovic closed this as completed in #1641 Jun 5, 2020

aleksandrmelnikov mentioned this issue Oct 27, 2020

Expand CVAT flexibility by adding more environment variables to cvat/settings/base.py #2362

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add more environment variables to configure CVAT container #445

Add more environment variables to configure CVAT container #445

ppanczyk commented May 8, 2019

nmanovic commented May 12, 2019

amiralipour commented Aug 23, 2019

inealey commented Oct 14, 2019

amiralipour commented Oct 14, 2019

nmanovic commented Oct 15, 2019

valiantljk commented Oct 18, 2019

Langhalsdino commented Nov 28, 2019 •

edited

Loading

nmanovic commented Nov 28, 2019

Langhalsdino commented Nov 28, 2019

nmanovic commented Nov 28, 2019

valiantljk commented Jan 7, 2020

Langhalsdino commented Jan 7, 2020 •

edited

Loading

ofaz commented Feb 13, 2020

Langhalsdino commented Feb 13, 2020 •

edited

Loading

atemate commented Feb 19, 2020

Langhalsdino commented Feb 24, 2020 •

edited

Loading

Langhalsdino commented Feb 24, 2020

TaSeeMba commented Oct 1, 2020

Langhalsdino commented Oct 1, 2020

jizg commented Oct 11, 2020 •

edited

Loading

Add more environment variables to configure CVAT container #445

Add more environment variables to configure CVAT container #445

Comments

ppanczyk commented May 8, 2019

nmanovic commented May 12, 2019

amiralipour commented Aug 23, 2019

inealey commented Oct 14, 2019

amiralipour commented Oct 14, 2019

nmanovic commented Oct 15, 2019

valiantljk commented Oct 18, 2019

Langhalsdino commented Nov 28, 2019 • edited Loading

nmanovic commented Nov 28, 2019

Langhalsdino commented Nov 28, 2019

nmanovic commented Nov 28, 2019

valiantljk commented Jan 7, 2020

Langhalsdino commented Jan 7, 2020 • edited Loading

ofaz commented Feb 13, 2020

Langhalsdino commented Feb 13, 2020 • edited Loading

atemate commented Feb 19, 2020

Langhalsdino commented Feb 24, 2020 • edited Loading

Langhalsdino commented Feb 24, 2020

TaSeeMba commented Oct 1, 2020

Langhalsdino commented Oct 1, 2020

jizg commented Oct 11, 2020 • edited Loading

Langhalsdino commented Nov 28, 2019 •

edited

Loading

Langhalsdino commented Jan 7, 2020 •

edited

Loading

Langhalsdino commented Feb 13, 2020 •

edited

Loading

Langhalsdino commented Feb 24, 2020 •

edited

Loading

jizg commented Oct 11, 2020 •

edited

Loading