Add environment variables for Redis and Postgres hosts #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added environment variables for: - Redis Host - Postgres Host - Change `POSTGRES_PASSWORD` => `CVAT_POSTGRES_PASSWORD` to avoid collision with other scripts.
Update to support additional env vars
Pull Request Test Coverage Report for Build 5456
💛 - Coveralls |
rushtehrani
changed the title
|
@rushtehrani , thank you very much for the PR. Could you please add the a line into CHANGELOG.md file? It is the only comment I have for the PR. |
|
@nmanovic done |
|
@azhavoro , could you please test the patch and merge? It looks very well for me. |
nmanovic
approved these changes
Jun 5, 2020
412b
added a commit
to 412b/cvat
that referenced
this pull request
Jun 23, 2020
Added env variables for Postgres DB and user names
nmanovic
pushed a commit
that referenced
this pull request
Jun 23, 2020
8 tasks
frndmg
pushed a commit
to signatrix/cvat
that referenced
this pull request
Aug 5, 2020
* Update to support additional env vars - Added environment variables for: - Redis Host - Postgres Host - Change `POSTGRES_PASSWORD` => `CVAT_POSTGRES_PASSWORD` to avoid collision with other scripts. * Using ENV vars in supervisord.conf * Fixing ENV vars. * add env vars to docker-compose.yml * merge supervisord.conf * update docker-compose env var values * Update CHANGELOG.md Co-authored-by: Aleksandr Melnikov <aleksandr@onepanel.io> Co-authored-by: Nikita Manovich <40690625+nmanovic@users.noreply.github.com>
frndmg
pushed a commit
to signatrix/cvat
that referenced
this pull request
Aug 5, 2020
Added env variables for Postgres DB and user names
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Fixes #445
These are the changes made to make it so that CVAT can run on Kubernetes:
POSTGRES_PASSWORD=>CVAT_POSTGRES_PASSWORDto avoid collision with other environments. Note this change could backwards compatibility for certain users.We are submitting this PR for review and additional discussion. We will update documentation and tests (if applicable) once we have indication that these changes can be merged.
How has this been tested?
We are running CVAT on Onepanel which is based on Kubernetes and with these changes, we have been able to make CVAT work in a Kubernetes environment.
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.