Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing SEMI-AUTO source of annotation #6261

Closed
2 tasks done
pktiuk opened this issue Jun 7, 2023 · 3 comments · Fixed by #6263
Closed
2 tasks done

Missing SEMI-AUTO source of annotation #6261

pktiuk opened this issue Jun 7, 2023 · 3 comments · Fixed by #6263
Labels
enhancement New feature or request

Comments

@pktiuk
Copy link
Contributor

pktiuk commented Jun 7, 2023

My actions before raising this issue

According to docs there are 3 sources of annotation

Source- source of creating of objects MANUAL, AUTO or SEMI-AUTO.

But case of SEMI-AUTO is not handled anywhere in CVAT UI (or in source code).

Steps to Reproduce (for bugs)

  1. Create annotation with semi-auto source
    • either export annotations.xml with source
<track id="0" label="mbt" source="semi-auto">
  • Use cvat SDK
LabeledShapeRequest(type=ShapeType("mask"),

                                                  occluded=bool(int(obj["occluded"])),
                                                  source="semi-auto",
                                                  outside=False,
                                                  z_order=0,
                                                  rotation=0.0,
                                                  label_id=mappings_project_labels[obj["label"]],
                                                  points=obj["rle"] + [obj["xtl"], obj["ytl"], obj["xbr"] - 1, obj["ybr"] - 1],
                                                  frame=frame_id))
  1. See it in CVAT ui

Expected Behaviour

Visible source should be SEMI-AUTO

Current Behaviour

It shows MANUAL

Possible Solution

Implement handling it.

Context

Your Environment

CVAT 2.4.5

@bsekachev
Copy link
Member

@pktiuk

I think it is a documentation issue. We never have something like "semi-auto" in CVAT.

@bsekachev bsekachev added the documentation Documentation should be updated label Jun 7, 2023
@pktiuk
Copy link
Contributor Author

pktiuk commented Jun 7, 2023

@bsekachev

But I think this semi-auto may be very useful. Especially in case of annotating with SAM. I can implement support of this feature.

@bsekachev
Copy link
Member

You are always welcome to implement that

@bsekachev bsekachev added enhancement New feature or request and removed documentation Documentation should be updated labels Jun 7, 2023
bsekachev added a commit that referenced this issue Jun 8, 2023
Closes: #6261

<!-- Provide a general summary of your changes in the Title above -->

### Motivation and context
<!-- Why is this change required? What problem does it solve? If it
fixes an open
issue, please link to the issue here. Describe your changes in detail,
add
screenshots. -->

This kind of annotations was already mentioned in docs, but it was not
implemented.

### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->

I just deployed it with help of the docker-compose.dev.yml you provided.

### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [X] I submit my changes into the `develop` branch
- [X] I have added a description of my changes into the
[CHANGELOG](https://github.com/opencv/cvat/blob/develop/CHANGELOG.md)
file
- [ ] I have updated the documentation accordingly. (it was already in
docs)
- [ ] I have added tests to cover my changes
- [X] I have linked related issues (see [GitHub docs](

https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [x] I have increased versions of npm packages if it is necessary

([cvat-canvas](https://github.com/opencv/cvat/tree/develop/cvat-canvas#versioning),

[cvat-core](https://github.com/opencv/cvat/tree/develop/cvat-core#versioning),

[cvat-data](https://github.com/opencv/cvat/tree/develop/cvat-data#versioning)
and

[cvat-ui](https://github.com/opencv/cvat/tree/develop/cvat-ui#versioning))

### License

- [X] I submit _my code changes_ under the same [MIT License](
https://github.com/opencv/cvat/blob/develop/LICENSE) that covers the
project.
  Feel free to contact the maintainers if that's a concern.

---------

Co-authored-by: Boris Sekachev <boris.sekachev@yandex.ru>
Co-authored-by: Boris Sekachev <sekachev.bs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants