Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click or Hover one left menu when annotating #6616

Closed
DaveBGld opened this issue Aug 3, 2023 · 2 comments · Fixed by #6817
Closed

Click or Hover one left menu when annotating #6616

DaveBGld opened this issue Aug 3, 2023 · 2 comments · Fixed by #6817
Assignees
Labels
bug Something isn't working ui/ux

Comments

@DaveBGld
Copy link

DaveBGld commented Aug 3, 2023

When I am in the annotation window on a job, there is a vertical menu with tools on the left hand side.

These tools are activated by hovering only. If by mistake I clicked, the tool disappears, and now I need to hover....

I think that the UX would be better if the tool is activated also by clicking on it.

Also, I think it would be an improvement if the tool stays active with the same settings even after clicking done or Shift-N so the user con repeat the previous annotation, until esc is pressed, or another tool is selected...

DBG

@bsekachev
Copy link
Member

The first is clear. About the second one:

Also, I think it would be an improvement if the tool stays active with the same settings even

Could you clarify? As I remeber it works now exactly this way. If you created a rectangle from external points, than pressing N again it will again create rectangle from external points. Or you mean issue like this one #3474 when an object was created with any automatic tool, on Shift + N is being redrawn as a regular one?

@bsekachev bsekachev added ui/ux bug Something isn't working labels Aug 4, 2023
@bsekachev bsekachev self-assigned this Aug 4, 2023
bsekachev added a commit that referenced this issue Sep 6, 2023
<!-- Raise an issue to propose your change
(https://github.com/opencv/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution
guide](https://opencv.github.io/cvat/docs/contributing/). -->

<!-- Provide a general summary of your changes in the Title above -->

### Motivation and context
Resolved #6616

Before:

![before](https://github.com/opencv/cvat/assets/40690378/329c5bd0-1c89-4a00-a2a3-e44481d9bbdf)

After:

![after](https://github.com/opencv/cvat/assets/40690378/2e45bf2e-822c-45b5-ae8c-9a2ab3e66ca6)

### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->

### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- [x] I have added a description of my changes into the
[CHANGELOG](https://github.com/opencv/cvat/blob/develop/CHANGELOG.md)
file
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [ ] I have linked related issues (see [GitHub docs](

https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [x] I have increased versions of npm packages if it is necessary

([cvat-canvas](https://github.com/opencv/cvat/tree/develop/cvat-canvas#versioning),

[cvat-core](https://github.com/opencv/cvat/tree/develop/cvat-core#versioning),

[cvat-data](https://github.com/opencv/cvat/tree/develop/cvat-data#versioning)
and

[cvat-ui](https://github.com/opencv/cvat/tree/develop/cvat-ui#versioning))

### License

- [x] I submit _my code changes_ under the same [MIT License](
https://github.com/opencv/cvat/blob/develop/LICENSE) that covers the
project.
  Feel free to contact the maintainers if that's a concern.
@DaveBGld
Copy link
Author

DaveBGld commented Sep 6, 2023

@bsekachev Thank you!

mikhail-treskin pushed a commit to retailnext/cvat that referenced this issue Oct 25, 2023
<!-- Raise an issue to propose your change
(https://github.com/opencv/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution
guide](https://opencv.github.io/cvat/docs/contributing/). -->

<!-- Provide a general summary of your changes in the Title above -->

### Motivation and context
Resolved cvat-ai#6616

Before:

![before](https://github.com/opencv/cvat/assets/40690378/329c5bd0-1c89-4a00-a2a3-e44481d9bbdf)

After:

![after](https://github.com/opencv/cvat/assets/40690378/2e45bf2e-822c-45b5-ae8c-9a2ab3e66ca6)

### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->

### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- [x] I have added a description of my changes into the
[CHANGELOG](https://github.com/opencv/cvat/blob/develop/CHANGELOG.md)
file
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [ ] I have linked related issues (see [GitHub docs](

https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [x] I have increased versions of npm packages if it is necessary

([cvat-canvas](https://github.com/opencv/cvat/tree/develop/cvat-canvas#versioning),

[cvat-core](https://github.com/opencv/cvat/tree/develop/cvat-core#versioning),

[cvat-data](https://github.com/opencv/cvat/tree/develop/cvat-data#versioning)
and

[cvat-ui](https://github.com/opencv/cvat/tree/develop/cvat-ui#versioning))

### License

- [x] I submit _my code changes_ under the same [MIT License](
https://github.com/opencv/cvat/blob/develop/LICENSE) that covers the
project.
  Feel free to contact the maintainers if that's a concern.
@github-project-automation github-project-automation bot moved this to Done in UI Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui/ux
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants