Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag annotation not similar with Ground Truth #8547

Closed
2 tasks done
davy-blavette opened this issue Oct 16, 2024 · 4 comments
Closed
2 tasks done

Tag annotation not similar with Ground Truth #8547

davy-blavette opened this issue Oct 16, 2024 · 4 comments
Assignees
@klakhov
Labels
bug Something isn't working

Comments

@davy-blavette
Copy link

davy-blavette commented Oct 16, 2024 •
edited
Loading

Actions before raising this issue

  • I searched the existing issues and did not find anything similar.
  • I read/searched the docs

Is your feature request related to a problem? Please describe.

I don't know why there's a difference between tags entered on a task and tags entered on ground truth. On GT you can add the GT tag, why not (in case you don't know?!), but you no longer have the option of deleting it. Is there a particular reason for this or is it an oversight?

image
image

Describe the solution you'd like

Add the possibility to delete with a cross

Describe alternatives you've considered

No response

Additional context

No response
@davy-blavette davy-blavette added the enhancement New feature or request label Oct 16, 2024
@klakhov
Copy link
Contributor

klakhov commented Oct 16, 2024

Hi @davy-blavette,

If I understand correctly, in the first screenshot, you’re viewing the tag inside the ground truth (GT) job, and in the second screenshot, it's in a regular job. Ground truth annotations are separate from regular jobs, meaning they cannot be deleted or edited in regular jobs. This applies not only to tags but to all kinds of annotations.

GT annotations can only be viewed in review mode, and the purpose of this is to identify conflicts between regular annotations and ground truth. You can either create an issue for the annotator or switch back to standard mode to edit the regular annotations and resolve the conflict.

@davy-blavette
Copy link
Author

Thanks @klakhov for your answer!
I'm talking about the fact that adding a tag to the ground truth job doesn't make it easy to delete it at the moment because there's no cross like on a normal job, the first screen corresponds to the GT view... at the moment it's not very practical because you have to press SHIFT + N to delete the tag.

I also have another problem, but it's specific to my use, I add issues (in api mode) to the GT because it's generated automatically with the inference values, in input mode the review disappears so I don't have the information to change my tag, I spend my time switching between GT review and GT annotation tag which isn't very practical.

image
image

@klakhov
Copy link
Contributor

klakhov commented Oct 17, 2024

Now I see, it seems in gt job we also dont have a cross, looks like a bug, I will look into this.

Also it seems we need to add some setting for tag annotation mode to show issues.

@klakhov klakhov self-assigned this Oct 17, 2024
@klakhov klakhov mentioned this issue Oct 23, 2024
Merged
7 tasks
klakhov added a commit that referenced this issue Oct 29, 2024
@klakhov
Improved Ground truth tags (#8586)
251054b 
<!-- Raise an issue to propose your change
(https://github.com/cvat-ai/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution guide](https://docs.cvat.ai/docs/contributing/).
-->

<!-- Provide a general summary of your changes in the Title above -->

### Motivation and context
<!-- Why is this change required? What problem does it solve? If it
fixes an open
issue, please link to the issue here. Describe your changes in detail,
add
screenshots. -->

Fixed several issues:
- GT tags are rendered with `(GT)` mark inside of GT job which is not
correct
- GT tags can not be deleted via `x` button inside the GT job

Other improvements:
- Refactored `frame-tags` component code
- Improved styles for gt/non-gt tags, as they are too close:

![image](https://github.com/user-attachments/assets/a5b1c055-4ee0-4469-ada2-21a6a70146ee)
->

![image](https://github.com/user-attachments/assets/49eb4625-1690-4865-b94f-973cee351183)

Related #8547
### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->

### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- [ ] I have created a changelog fragment <!-- see top comment in
CHANGELOG.md -->
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [ ] I have linked related issues (see [GitHub docs](

https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [ ] I have increased versions of npm packages if it is necessary

([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning),

[cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning),

[cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning)
and

[cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning))

### License

- [x] I submit _my code changes_ under the same [MIT License](
https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the
project.
  Feel free to contact the maintainers if that's a concern.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced state management in the FrameTags component for improved
performance and readability.
- Introduced a new CSS class to manage spacing in the tag annotation
workspace.

- **Bug Fixes**
	- Updated tag filtering logic to improve accuracy in displaying tags.

- **Refactor**
- Simplified component structure by utilizing hooks for state
management.
	- Optimized rendering logic and performance with memoization.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@klakhov klakhov added bug Something isn't working and removed enhancement New feature or request labels Nov 8, 2024
@klakhov
Copy link
Contributor

klakhov commented Nov 8, 2024

Hi @davy-blavette,

I’ll be closing this issue since the main problem you reported (which was more of a bug) has now been resolved. If you still would like to request displaying issues in tag annotation mode, please feel free to open a new issue for that.

@klakhov klakhov closed this as completed Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@klakhov klakhov

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davy-blavette @klakhov