Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: Uncaught TypeError: Cannot read property 'nodeValue' of undefined #1068

Merged
merged 1 commit into from
Jan 17, 2020
Merged

Fixed: Uncaught TypeError: Cannot read property 'nodeValue' of undefined #1068

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cvat/apps/engine/static/engine/js/shapeCreator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,9 @@ class ShapeCreatorView {
};

let numberOfPoints = 0;
this._drawInstance.attr({
z_order: Number.MAX_SAFE_INTEGER,
});

if (this._polyShapeSize) {
let size = this._polyShapeSize;
Expand Down Expand Up @@ -467,6 +470,7 @@ class ShapeCreatorView {
case 'box':
this._drawInstance = this._frameContent.rect().draw({ snapToGrid: 0.1 }).addClass('shapeCreation').attr({
'stroke-width': STROKE_WIDTH / this._scale,
z_order: Number.MAX_SAFE_INTEGER,
}).on('drawstop', function(e) {
if (this._cancel) return;
if (sizeUI) {
Expand Down Expand Up @@ -545,10 +549,6 @@ class ShapeCreatorView {
default:
throw Error(`Bad type found ${this._type}`);
}

this._drawInstance.attr({
'z_order': Number.MAX_SAFE_INTEGER,
});
}

_rescaleDrawPoints() {
Expand Down