Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix frame step export for image tasks #1615

Merged
merged 7 commits into from
Jun 15, 2020
Merged

Fix frame step export for image tasks #1615

merged 7 commits into from
Jun 15, 2020

Conversation

zhiltsov-max
Copy link
Contributor

@zhiltsov-max zhiltsov-max commented May 29, 2020 •
edited
Loading

Closes #1613

Motivation and context

Internally annotations and images are stored contiguously, while on the outside they have absolute numbers. This was not so everywhere.

How has this been tested?

Manual testing

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@zhiltsov-max zhiltsov-max linked an issue May 29, 2020 that may be closed by this pull request
Dump annotations with frame step: Key error #1613
Closed
@coveralls
Copy link

coveralls commented May 29, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 5491

  • 12 of 12 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 65.692%
Totals Coverage Status
Change from base Build 5489: 0.006%
Covered Lines: 10899
Relevant Lines: 16184
💛 - Coveralls

@nmanovic
Copy link
Contributor

@azhavoro , could you please look at the PR and test it?

@nmanovic nmanovic requested a review from azhavoro May 29, 2020 11:18
azhavoro
azhavoro previously approved these changes May 29, 2020
View reviewed changes
Base automatically changed from release-1.0.0 to develop June 2, 2020 04:04
@nmanovic nmanovic dismissed azhavoro’s stale review June 2, 2020 04:04

The base branch was changed.

azhavoro
azhavoro previously approved these changes Jun 3, 2020
View reviewed changes
azhavoro
azhavoro previously approved these changes Jun 10, 2020
View reviewed changes
@azhavoro
Copy link
Contributor

@nmanovic Could you please merge? I have no rights...

nmanovic
nmanovic previously approved these changes Jun 15, 2020
View reviewed changes
@nmanovic nmanovic dismissed stale reviews from azhavoro and themself via f170f52 June 15, 2020 12:26
@nmanovic nmanovic merged commit 1fb7e5b into develop Jun 15, 2020
@zhiltsov-max zhiltsov-max mentioned this pull request Jun 16, 2020
Merged
8 tasks
@zhiltsov-max zhiltsov-max mentioned this pull request Jun 16, 2020
Merged
7 tasks
@azhavoro azhavoro deleted the zm/fix-frame-step branch June 17, 2020 14:13
frndmg pushed a commit to signatrix/cvat that referenced this pull request Aug 5, 2020
@zhiltsov-max @nmanovic
Fix frame step export for image tasks (cvat-ai#1615)
b27f2b4 
* use absolute frame numbers in interface

* update changelog

Co-authored-by: Nikita Manovich <40690625+nmanovic@users.noreply.github.com>
@snyk-bot snyk-bot mentioned this pull request Oct 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azhavoro azhavoro azhavoro left review comments

@nmanovic nmanovic nmanovic left review comments

Assignees

@nmanovic nmanovic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dump annotations with frame step: Key error
4 participants
@zhiltsov-max @coveralls @nmanovic @azhavoro