Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Datumaro] Add DatasetItem attributes #1639

Merged
merged 3 commits into from
Jun 8, 2020
Merged

[Datumaro] Add DatasetItem attributes #1639

merged 3 commits into from
Jun 8, 2020

Conversation

zhiltsov-max
Copy link
Contributor

@zhiltsov-max zhiltsov-max commented Jun 3, 2020 •
edited
Loading

Motivation and context

Preparation commit for #1463.

Added DatasetItem attributes. Added their support in Datumaro file format.

How has this been tested?

Unit tests.

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@zhiltsov-max zhiltsov-max changed the title [Datumaro] Add item attributes [Datumaro] Add DatasetItem attributes Jun 3, 2020
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5440

  • 10 of 10 (100.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 65.676%
Files with Coverage Reduction New Missed Lines %
datumaro/datumaro/components/extractor.py 1 90.7%
Totals Coverage Status
Change from base Build 5409: 0.03%
Covered Lines: 10845
Relevant Lines: 16109
💛 - Coveralls

nmanovic
nmanovic approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmanovic nmanovic merged commit ba309c8 into develop Jun 8, 2020
@nmanovic nmanovic deleted the zm/add-item-attributes branch June 9, 2020 12:41
frndmg pushed a commit to signatrix/cvat that referenced this pull request Aug 5, 2020
@zhiltsov-max
[Datumaro] Add DatasetItem attributes (cvat-ai#1639)
c7d33b1 
* Add DatasetItem attributes

* Update tests

* Update datumaro format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmanovic nmanovic nmanovic approved these changes

@azhavoro azhavoro azhavoro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhiltsov-max @coveralls @nmanovic @azhavoro