Fixed activation bug with frame switching #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5477
💛 - Coveralls |
bsekachev
reviewed
Jun 4, 2020
| @@ -571,7 +571,7 @@ export default class CanvasWrapperComponent extends React.PureComponent<Props> { | |||
| canvasInstance.fit(); | |||
| } | |||
| } | |||
| if (activatedState.objectType !== ObjectType.TAG) { | |||
| if (activatedState && activatedState.objectType !== ObjectType.TAG) { | |||
There was a problem hiding this comment.
How can we get situation when activatedStateID !== null, but it isn't contained in annotations?
There was a problem hiding this comment.
@bsekachev, have no idea but in some situations we have annotations with empty list
There was a problem hiding this comment.
Probably we should investigate the root cause. It looks like workaround.
At least need to understand the reason
There was a problem hiding this comment.
@bsekachev, i guess we can recreate an issue for further investigation and commit this changes to avoid canvas failing. What do you think?
There was a problem hiding this comment.
Yep. Nice way. Could you create it?
2 tasks
bsekachev
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
This PR fixed #1611
How has this been tested?
Manually
Checklist
developbranch- [ ] I have updated the documentation accordingly- [ ] I have added tests to cover my changescvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.