-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Datumaro] Image control in converters #1799
Conversation
@nmanovic, how do you think, should we add an option of making symlinks instead of copying? |
@zhiltsov-max could you fix conflicts? |
@azhavoro, done. Is there a way to obtain really original images? I mean, a path to the raw image. The problem is that once read, jpeg images can't be saved with original quality, even if saving with 100% quality. PNG images are likely to lose their compression. So, since we've learned to just copy images on export, it makes sense to support it in CVAT too. Also, it potentially should give a significant performance boost for export. An example - an original (raw) PNG was 43 kb, exported became 60. |
@zhiltsov-max , could you please resolve conflicts? |
Complexity increasing per file
==============================
- datumaro/datumaro/components/converter.py 2
Complexity decreasing per file
==============================
+ datumaro/datumaro/plugins/tf_detection_api_format/extractor.py -1
See the complete overview on Codacy |
Motivation and context
Converter
class interface. Now it should be invoked withConverter.convert(...)
. Converter definition simplified.How has this been tested?
Unit tests.
How to test:
Checklist
develop
branchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.