Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes: Propagation from the latest frame, number attribute validation #1800

Merged
merged 3 commits into from
Jun 24, 2020

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Jun 24, 2020

  1. Fixed propagation from the latest frame (issue of cvat-core)
  2. Fixed number validation (didn't work well with floats, issue of cvat-core)
  3. Adjusted attribute validation messages in cvat-ui

Resolve #1785

Motivation and context

Some issues have been found and reported. Need to fix them

How has this been tested?

Manual testing

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bsekachev bsekachev added the bug Something isn't working label Jun 24, 2020
@bsekachev bsekachev self-assigned this Jun 24, 2020
@bsekachev bsekachev added this to the 1.1.0-alpha milestone Jun 24, 2020
@coveralls
Copy link

coveralls commented Jun 24, 2020

Pull Request Test Coverage Report for Build 6150

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 184 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.003%) to 65.134%

Files with Coverage Reduction New Missed Lines %
cvat/apps/engine/media_extractors.py 1 77.35%
src/annotations-collection.js 29 63.37%
src/annotations-objects.js 154 62.15%
Totals Coverage Status
Change from base Build 6122: 0.003%
Covered Lines: 11007
Relevant Lines: 16487

💛 - Coveralls

@nmanovic nmanovic merged commit db24f93 into develop Jun 24, 2020
@bsekachev bsekachev deleted the bs/batch_of_fixes_1 branch June 25, 2020 10:49
frndmg pushed a commit to signatrix/cvat that referenced this pull request Aug 5, 2020
…tion (cvat-ai#1800)

* Improved messages for number attribute validation, fixed propagation from the latest frame, fixed checking of a number attribute

* Updated versions

* Updated changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Propagation doesn't work from the latest frame
3 participants