-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated auto annotation runner to use new auto annotation api #1826
Conversation
Pull Request Test Coverage Report for Build 6278
💛 - Coveralls |
Tested locally, there is one person who reports an error running the code in the original issue (following up with that person currently), so might be worth testing on before pulling. |
@nmanovic , let me take a look tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benhoff Hi, thanks for the PR, regarding the issue with TypeError: argument of type 'NoneType' is not iterable I suppose this line
(https://github.com/benhoff/cvat/blob/runfile/cvat/apps/auto_annotation/inference.py#L153) should be changed like this:
label_attr_spec = self.attribute_spec.get(db_label, dict())
@benhoff , thanks for all your contributions. I will close the PR because soon the updated files will be removed. |
Motivation and context
See: #1798
Note that the API was changed in 8a2efa4 to not continually add to a list. Users were reporting issues with large video files consuming all the RAM, so we went to a more iterative API.
How has this been tested?
Sorry, I don't have an active CVAT installation. This was not tested.
Checklist
develop
branchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.