Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated auto annotation runner to use new auto annotation api #1826

Closed
wants to merge 1 commit into from

Conversation

benhoff
Copy link
Contributor

@benhoff benhoff commented Jun 30, 2020

Motivation and context

See: #1798
Note that the API was changed in 8a2efa4 to not continually add to a list. Users were reporting issues with large video files consuming all the RAM, so we went to a more iterative API.

How has this been tested?

Sorry, I don't have an active CVAT installation. This was not tested.

Checklist

License

  • [ x ] I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • [x ] I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@coveralls
Copy link

coveralls commented Jun 30, 2020

Pull Request Test Coverage Report for Build 6278

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.009%) to 65.154%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cvat/apps/auto_annotation/inference.py 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
cvat/apps/engine/media_extractors.py 2 77.06%
Totals Coverage Status
Change from base Build 6272: -0.009%
Covered Lines: 11048
Relevant Lines: 16548

💛 - Coveralls

@benhoff benhoff changed the title updated auto annotation runner to use new auto annotation api [WIP] updated auto annotation runner to use new auto annotation api Jul 1, 2020
@nmanovic
Copy link
Contributor

nmanovic commented Jul 1, 2020

 @benhoff , could you please look at #1767 and give your opinion?

@benhoff benhoff changed the title [WIP] updated auto annotation runner to use new auto annotation api updated auto annotation runner to use new auto annotation api Jul 2, 2020
@benhoff
Copy link
Contributor Author

benhoff commented Jul 2, 2020

Tested locally, there is one person who reports an error running the code in the original issue (following up with that person currently), so might be worth testing on before pulling.

@benhoff
Copy link
Contributor Author

benhoff commented Jul 2, 2020

@nmanovic , let me take a look tomorrow.

Copy link
Contributor

@azhavoro azhavoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benhoff Hi, thanks for the PR, regarding the issue with TypeError: argument of type 'NoneType' is not iterable I suppose this line
(https://github.com/benhoff/cvat/blob/runfile/cvat/apps/auto_annotation/inference.py#L153) should be changed like this:

label_attr_spec = self.attribute_spec.get(db_label, dict())

@nmanovic
Copy link
Contributor

nmanovic commented Jul 8, 2020

@benhoff , thanks for all your contributions. I will close the PR because soon the updated files will be removed.

@nmanovic nmanovic closed this Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants