Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CVAT-UI] Critical fixes #1874

Merged
merged 10 commits into from
Jul 9, 2020
Merged

[CVAT-UI] Critical fixes #1874

merged 10 commits into from
Jul 9, 2020

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Jul 9, 2020

Motivation and context

The PR fixes several issues reported by internal team and open source community
@ActiveChooN Please, review it ASAP

How has this been tested?

Manual testing

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

Resolve #1841
Resolve #1870
Resolve #1861

@bsekachev bsekachev added the bug Something isn't working label Jul 9, 2020
@bsekachev bsekachev changed the title Bs/batch of fixes [CVAT-UI] Critical fixes Jul 9, 2020
@coveralls
Copy link

coveralls commented Jul 9, 2020

Pull Request Test Coverage Report for Build 6354

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 65.17%

Files with Coverage Reduction New Missed Lines %
datumaro/datumaro/components/project.py 1 78.41%
cvat/apps/engine/media_extractors.py 3 75.29%
Totals Coverage Status
Change from base Build 6342: -0.02%
Covered Lines: 11054
Relevant Lines: 16556

💛 - Coveralls

@bsekachev bsekachev added this to the 1.1.0-beta milestone Jul 9, 2020
cvat-ui/package.json Outdated Show resolved Hide resolved
ActiveChooN
ActiveChooN previously approved these changes Jul 9, 2020
Copy link
Contributor

@ActiveChooN ActiveChooN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsekachev bsekachev requested a review from nmanovic as a code owner July 9, 2020 14:17
@bsekachev bsekachev merged commit 2a5cfcc into develop Jul 9, 2020
@bsekachev bsekachev deleted the bs/batch_of_fixes branch July 15, 2020 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants