-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare chunks on the fly #2007
Conversation
* moved cache implementation * fixed start, stop, step for tasks that created on the fly * changed frame provider
Pull Request Test Coverage Report for Build 7244
💛 - Coveralls |
@Marishka17 , need to fix a couple of codacy issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Client part LGTM. I have only one question. Should we enable the option useCache
by default if it doesn't work for all videos?
@bsekachev , ok i will change default value. |
@Marishka17 , need to resolve conflicts. |
LGTM, but need to fix a couple of minor comments and add some tests. |
HI,When does this pr merge |
I have merged the PR with some minor modifications manually. |
Motivation and context
Currently, when creating a task, original and compressed chunks are prepared.
This takes a significant amount of time and consumes a lot of disk space.
This PR contains a new way to create a task.
At the time of task creation minimum necessary information about the loaded data is collected.
(mapping of key frames and timestamps for video, dummy chunks for images).
Chunks are created "on the fly" when a request for needed chunk is received.
Created chunks are stored in a temporary cache of limited size.
How has this been tested?
Manually
Checklist
develop
branchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.