Added password reset functionality #2058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7232
💛 - Coveralls |
|
@azhavoro Please, resolve some conflicts |
bsekachev
reviewed
Aug 24, 2020
| <Row type='flex' justify='start' align='top'> | ||
| <Col> | ||
| <Text strong> | ||
| Already have an account? |
There was a problem hiding this comment.
I suppose this text isn't expected here. Something like Go to login page would be better
cvat-ui/src/components/reset-password-page/reset-password-form.tsx
Outdated
Show resolved
Hide resolved
cvat-ui/src/components/reset-password-page/reset-password-form.tsx
Outdated
Show resolved
Hide resolved
cvat-ui/src/components/reset-password-confirm-page/reset-password-confirm-page.tsx
Outdated
Show resolved
Hide resolved
| ...values, | ||
| uid, | ||
| token, | ||
| confirmations: [], |
There was a problem hiding this comment.
Why do we need this empty array?
There was a problem hiding this comment.
My bad, ctrl+c, ctrl+v....
bsekachev
reviewed
Aug 24, 2020
cvat-ui/src/components/reset-password-confirm-page/reset-password-confirm-page.tsx
Outdated
Show resolved
Hide resolved
|
LGTM, @ActiveChooN, could you please also take a look to this PR? |
bsekachev
previously approved these changes
Aug 31, 2020
ActiveChooN
reviewed
Aug 31, 2020
cvat-ui/src/components/reset-password-confirm-page/reset-password-confirm-form.tsx
Outdated
Show resolved
Hide resolved
cvat-ui/src/components/reset-password-confirm-page/reset-password-confirm-page.tsx
Outdated
Show resolved
Hide resolved
nmanovic
reviewed
Aug 31, 2020
cvat-ui/src/components/reset-password-confirm-page/reset-password-confirm-form.tsx
Outdated
Show resolved
Hide resolved
…ord-confirm-form.tsx
ActiveChooN
approved these changes
Sep 1, 2020
bsekachev
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #1600
Added password reset functionality
Motivation and context
How has this been tested?
manual testing
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.