Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used addEventListener instead of overriding window.onerror for global error handling #2079

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

azhavoro
Copy link
Contributor

Used addEventListener instead of overriding window.onerror for global error handling

Motivation and context

The global error handler can be overridden by web analytic framework and part of errors may be uncaught.

How has this been tested?

Manually

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7099

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 69.729%

Totals Coverage Status
Change from base Build 7097: 0.02%
Covered Lines: 11750
Relevant Lines: 16392

💛 - Coveralls

@bsekachev bsekachev merged commit 0d41866 into develop Aug 26, 2020
@bsekachev bsekachev deleted the az/onerror_overriding branch August 27, 2020 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants