Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial version of FBRS interactive segmentation #2094

Merged
merged 14 commits into from
Sep 9, 2020

Conversation

nmanovic
Copy link
Contributor

@nmanovic nmanovic commented Aug 27, 2020

Fix #1553

Motivation and context

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@nmanovic nmanovic changed the title Initial version of FBRS interactive segmentation [WIP] Initial version of FBRS interactive segmentation Aug 27, 2020
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7345

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.78%

Totals Coverage Status
Change from base Build 7341: 0.0%
Covered Lines: 12498
Relevant Lines: 17262

💛 - Coveralls

@nmanovic nmanovic changed the title [WIP] Initial version of FBRS interactive segmentation Initial version of FBRS interactive segmentation Sep 8, 2020
@nmanovic nmanovic merged commit 5ebd91a into develop Sep 9, 2020
@nmanovic
Copy link
Contributor Author

nmanovic commented Sep 9, 2020

@bsekachev , I have merged the patch. Now dextr and fbrs have min_pos_points parameter.

@nmanovic nmanovic deleted the nm/fbrs_interactive_segmentation branch September 9, 2020 15:47
@bsekachev
Copy link
Member

@bsekachev , I have merged the patch. Now dextr and fbrs have min_pos_points parameter.

Great, I will send a PR to client uses them

@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.78% when pulling 4b9ba4d on nm/fbrs_interactive_segmentation into 4e21929 on develop.

context.logger.info("call handler")
data = event.body
pos_points = data["points"]
neg_points = []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will the neg_points in the next implementation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate f-BRS interactive segmentation
3 participants