Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu 20.04 as a base image for CVAT Dockerfile #2101

Merged
merged 6 commits into from
Sep 2, 2020

Conversation

azhavoro
Copy link
Contributor

@azhavoro azhavoro commented Aug 31, 2020

Resolve #1930 resolve #1817 resolve #1457

Updated Ubuntu 20.04 as base image for CVAT container

Motivation and context

How has this been tested?

Manually tested + CI tests

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@nmanovic
Copy link
Contributor

@azhavoro , need to resolve the conflict.

@coveralls
Copy link

coveralls commented Aug 31, 2020

Pull Request Test Coverage Report for Build 7230

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.7%) to 70.399%

Files with Coverage Reduction New Missed Lines %
datumaro/datumaro/cli/main.py 1 0%
datumaro/datumaro/plugins/accuracy_checker_plugin/details/ac.py 1 4.17%
datumaro/datumaro/plugins/accuracy_checker_plugin/launcher.py 1 25.0%
datumaro/datumaro/util/init.py 1 78.49%
datumaro/datumaro/components/project.py 2 80.37%
datumaro/datumaro/plugins/openvino_launcher.py 4 3.95%
Totals Coverage Status
Change from base Build 7219: 0.7%
Covered Lines: 12040
Relevant Lines: 16700

💛 - Coveralls

Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update contribution guide?

Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a line into CHANGELOG

@nmanovic nmanovic merged commit 51ff630 into develop Sep 2, 2020
@nmanovic nmanovic deleted the az/update_docker_image branch September 2, 2020 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants