Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed blinking notification #2200

Merged
merged 2 commits into from
Sep 21, 2020
Merged

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Sep 20, 2020

Motivation and context

  • Fixed the blinking notification
  • A bit changed the notification message
  • Fixed bug when a task with 0 jobs is displayed as a completed

Resolve #2089

How has this been tested?

Manual testing

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bsekachev bsekachev added the bug Something isn't working label Sep 20, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 65.389% when pulling 2e43f4d on bs/fixed_blinking_notifications into 4a80959 on develop.

@bsekachev bsekachev merged commit 8330015 into develop Sep 21, 2020
@nmanovic nmanovic deleted the bs/fixed_blinking_notifications branch September 21, 2020 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blincking notification: Some tasks have not been showed because they do not have any data.
3 participants