Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed two issues #2053 and #2202 #2203

Merged
merged 4 commits into from
Sep 21, 2020
Merged

Fixed two issues #2053 and #2202 #2203

merged 4 commits into from
Sep 21, 2020

Conversation

bsekachev
Copy link
Member

Motivation and context

  1. Fixed use case when UI throws exception: Cannot read property 'objectType' of undefined (resolve UI exception: TypeError: Cannot read property 'objectType' of undefined #2053)
  2. Fixed use case when logs could be saved twice or more times (resolve Sometimes logs can be sent twice #2202)

How has this been tested?

Manual testing

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bsekachev bsekachev added the bug Something isn't working label Sep 20, 2020
@coveralls
Copy link

coveralls commented Sep 20, 2020

Coverage Status

Coverage decreased (-0.03%) to 65.356% when pulling e84d244 on bs/fixed_two_issues into 8330015 on develop.

@bsekachev bsekachev merged commit a93b460 into develop Sep 21, 2020
@bsekachev bsekachev deleted the bs/fixed_two_issues branch September 21, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sometimes logs can be sent twice UI exception: TypeError: Cannot read property 'objectType' of undefined
3 participants