-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockercompose version update 2.3 --> 3.3 #2235
Dockercompose version update 2.3 --> 3.3 #2235
Conversation
…o dockercompose-version-update
Hi, |
And looks like built is fault with these changes:
|
updated. |
@azhavoro What do you think about this PR? |
@bsekachev any update? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! Looks good from my perspective.
Please update documentation about "share_path" for version "3.3" (also for new users). I can't mount my dataset into docker. |
Did it work for 2.3, but doesn't work for 3.3? |
I believe there is version mismatch here: https://github.com/openvinotoolkit/cvat/blame/develop/cvat/apps/documentation/installation.md#L329 |
I updated it in the PR #2261 |
Motivation and Context
Resolves #2232
I have removed the
gateway
key because it was not supported in dockercompose file version3. But, if you specify subnet, docker automatically choose relevant gateway. So, dockercompose network gateway is still172.28.0.1
.Moreover, I have added
driver
key withdefault
value. docker-compose was already using default value.Checklist
develop
branchI have updated the documentation accordinglyI have added tests to cover my changesI have increased versions of npm packages if it is necessary (cvat-canvas,cvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
I have updated the license header for each file (see an example below)