Fixed polygon editing #2808
Merged
Fixed polygon editing #2808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsekachev
commented
Feb 15, 2021
| @@ -103,7 +105,7 @@ export class EditHandlerImpl implements EditHandler { | |||
|
|
|||
| this.editLine = (this.canvas as any).polyline(); | |||
| if (this.editData.state.shapeType === 'polyline') { | |||
| (this.editLine as any).on('drawpoint', (e: CustomEvent): void => { | |||
| (this.editLine as any).on('drawupdate', (e: CustomEvent): void => { | |||
There was a problem hiding this comment.
Only actual change in the PR. Others are to fix linter issues
There was a problem hiding this comment.
It is an extremely useful comment.
Sure. The test will be written. |
nmanovic
approved these changes
Feb 18, 2021
kenu
pushed a commit
to kenu/cvat
that referenced
this pull request
Feb 23, 2021
* Fixed polygon editing * Updated version & changelog * Try to restart codacy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved #2807
The bug appeared with this PR #2276 because of changing in implementation of svg.draw.js
@dvkruchinin Could you please write a test? Steps are described in the issue
Motivation and context
How has this been tested?
Manual testing
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.