Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed polygon editing #2808

Merged
merged 3 commits into from
Feb 18, 2021
Merged

Fixed polygon editing #2808

merged 3 commits into from
Feb 18, 2021

Conversation

bsekachev
Copy link
Member

Resolved #2807
The bug appeared with this PR #2276 because of changing in implementation of svg.draw.js

@dvkruchinin Could you please write a test? Steps are described in the issue

Motivation and context

How has this been tested?

Manual testing

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bsekachev bsekachev added the bug Something isn't working label Feb 15, 2021
@@ -103,7 +105,7 @@ export class EditHandlerImpl implements EditHandler {

this.editLine = (this.canvas as any).polyline();
if (this.editData.state.shapeType === 'polyline') {
(this.editLine as any).on('drawpoint', (e: CustomEvent): void => {
(this.editLine as any).on('drawupdate', (e: CustomEvent): void => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only actual change in the PR. Others are to fix linter issues

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is an extremely useful comment.

@dvkruchinin
Copy link
Contributor

Could you please write a test? Steps are described in the issue

Sure. The test will be written.

@coveralls
Copy link

coveralls commented Feb 15, 2021

Coverage Status

Coverage increased (+0.005%) to 70.834% when pulling 47c5163 on bs/fixed_issue_2807 into 7720a8f on develop.

@nmanovic nmanovic merged commit dc4760a into develop Feb 18, 2021
@nmanovic nmanovic deleted the bs/fixed_issue_2807 branch February 18, 2021 19:47
kenu pushed a commit to kenu/cvat that referenced this pull request Feb 23, 2021
* Fixed polygon editing
* Updated version & changelog
* Try to restart codacy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with polyline editing
5 participants