Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added validity check for polygon similarity computation related to issue #2851 #2852

Merged
merged 4 commits into from
Mar 4, 2021

Conversation

fengyach
Copy link
Contributor

@fengyach fengyach commented Feb 23, 2021

Resolve #2851

Motivation and context

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@fengyach fengyach changed the title Added validity check for polygon similarity computation related to issue #2851 Added validity check for polygon similarity computation Feb 23, 2021
@fengyach fengyach changed the title Added validity check for polygon similarity computation Added validity check for polygon similarity computation related to issue #2851 Feb 23, 2021
@coveralls
Copy link

coveralls commented Feb 23, 2021

Coverage Status

Coverage decreased (-0.05%) to 72.088% when pulling 6b26c36 on fengyach:bugfix/overlap_error into 1be3194 on openvinotoolkit:develop.

@nmanovic
Copy link
Contributor

@fengyach , could you please a line into CHANGELOG.md to reflex the fix?

@nmanovic
Copy link
Contributor

@fengyach , please update the PR header as well. There are several checks:

image

@fengyach
Copy link
Contributor Author

@fengyach , could you please a line into CHANGELOG.md to reflex the fix?

thank you for your comment! I will update my PR!

@fengyach fengyach requested a review from nmanovic as a code owner March 1, 2021 08:57
@zhiltsov-max
Copy link
Contributor

What do you think about this way of resolving the error?
https://stackoverflow.com/a/20873812

@fengyach
Copy link
Contributor Author

fengyach commented Mar 4, 2021

What do you think about this way of resolving the error?
https://stackoverflow.com/a/20873812

Hello! Apologies for the late response:

Yes we have, however we do have a few concerns regarding self-intersecting multipolygons. As this method would not fix that issue. And we would have to figure out which polygon (whether it is p1 or p2) that is invalid.

Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@nmanovic nmanovic merged commit 5f3cd44 into cvat-ai:develop Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export error when there are invalid polygons in the overlapping frames (shapely.errors.TopologicalError)
4 participants