-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added validity check for polygon similarity computation related to issue #2851 #2852
Conversation
@fengyach , could you please a line into CHANGELOG.md to reflex the fix? |
@fengyach , please update the PR header as well. There are several checks: |
thank you for your comment! I will update my PR! |
What do you think about this way of resolving the error? |
Hello! Apologies for the late response: Yes we have, however we do have a few concerns regarding self-intersecting multipolygons. As this method would not fix that issue. And we would have to figure out which polygon (whether it is p1 or p2) that is invalid. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
Resolve #2851
Motivation and context
How has this been tested?
Checklist
develop
branchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.