Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Migrated to Node 15, npm 7 #2885

Closed
wants to merge 9 commits into from
Closed

Conversation

bsekachev
Copy link
Member

Motivation and context

Resolved #2742

  • Used new concept of mono repository in NPM
  • Removed a lot of duplicated packages
  • Single package-lock.json, single npm ci to install
  • Migrated to webpack 5

@vnishukov Please, look if everything works fine on Mac.

P.S. Did not update for cypress testing yet, because

How has this been tested?

Manual testing

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bsekachev bsekachev added the enhancement New feature or request label Mar 1, 2021
@bsekachev bsekachev requested a review from nmanovic as a code owner March 1, 2021 10:32
@bsekachev
Copy link
Member Author

snyk error: Out of sync package.json and package-lock.json detected. Please run "npm install"
Probably is a false alarm (package-lock format was changed in npm 7 and probably snyk cannot work with it)

need to update eslint workflow to run the check successfully (@azhavoro , please look at changes in PR. What do you think?)

@bsekachev
Copy link
Member Author

Probably now is not the best time to migrate (no node 15 LTS yet, stricted support on CI, some big PRs are opened), let's wait some time before going in this way.

@bsekachev bsekachev closed this Mar 9, 2021
@nmanovic nmanovic deleted the bs/migration_npm7 branch August 6, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration from NPM 6 to NPM 7
1 participant