Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Changing a label on canvas does not work when 'Show object details' enabled #3084

Merged
merged 2 commits into from
Apr 13, 2021

Conversation

bsekachev
Copy link
Member

Motivation and context

Resolved #3083

How has this been tested?

Manual testing + CI

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bsekachev bsekachev added the bug Something isn't working label Apr 12, 2021
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 73.979% when pulling 30c9a22 on bs/issue_3083 into 7c5d71d on develop.

@bsekachev bsekachev changed the title [WIP] Fixed: Changing a label on canvas does not work when 'Show object details' enabled Fixed: Changing a label on canvas does not work when 'Show object details' enabled Apr 12, 2021
@bsekachev
Copy link
Member Author

bsekachev commented Apr 12, 2021

Hi @dvkruchinin

Can we update the corresponding test (with the checkbox from the PR title) trying to change a label?

@dvkruchinin
Copy link
Contributor

Hi @bsekachev

Can we update the corresponding test (with the checkbox from the PR title) trying to change a label?

Sure. I`ll do it.

@bsekachev bsekachev merged commit 085d260 into develop Apr 13, 2021
@bsekachev bsekachev mentioned this pull request Apr 13, 2021
8 tasks
@bsekachev bsekachev deleted the bs/issue_3083 branch April 13, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing a label on canvas does not work when "Show object details" enabled
3 participants