Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import annotations for frames with dots in name #3091

Merged
merged 10 commits into from
Apr 20, 2021

Conversation

sizov-kirill
Copy link
Contributor

@sizov-kirill sizov-kirill commented Apr 15, 2021

Motivation and context

Fixes #2473

How has this been tested?

Unit test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@coveralls
Copy link

coveralls commented Apr 16, 2021

Coverage Status

Coverage increased (+0.02%) to 74.079% when pulling b36c5f2 on sk/fix-import-annotations-for-YOLO-format into d2e4ee4 on develop.

f.DISPLAY_NAME in export_formats]
for format_name in formats:
if format_name == "VGGFace2 1.0":
self.skipTest("Format is disabled")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this format is disabled?

Copy link
Contributor Author

@sizov-kirill sizov-kirill Apr 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skipped the test for this format because VGGFace does not support annotations that are generated in the _generate_annotations(...) function. Same problem with ICDAR formats. I can specify annotations for these formats, but this will lead to a lot of code. So I would prefer to remove this test and include images with dots in filename in the test rest api: https://github.com/openvinotoolkit/cvat/blob/4ceb5da2447805c29ca4e20108bb2a2fb31ca6d3/cvat/apps/engine/tests/test_rest_api.py#L2966

Copy link
Contributor

@zhiltsov-max zhiltsov-max Apr 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the problem I wanted to highlight, was that the reason of skipping was not described in tests. Thus, a reader can't judge, whether this test already can be enabled or not.

@sizov-kirill sizov-kirill changed the title [WIP] Fix import annotations for frames with dots in name Fix import annotations for frames with dots in name Apr 20, 2021
@sizov-kirill sizov-kirill merged commit 4db05fd into develop Apr 20, 2021
@bsekachev bsekachev deleted the sk/fix-import-annotations-for-YOLO-format branch April 22, 2021 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot upload YOLO annotations generated from dump annotations
3 participants