Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some JS code was simplified by using css, a reported issue was fixed in this way #3289

Merged
merged 4 commits into from
Jun 8, 2021

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Jun 4, 2021

Motivation and context

Resolved #3250

How has this been tested?

Manual tested

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bsekachev bsekachev added the bug Something isn't working label Jun 4, 2021
@bsekachev bsekachev requested a review from nmanovic as a code owner June 4, 2021 11:17
@bsekachev bsekachev changed the title [WIP] Some JS code was simplified by using css Some JS code was simplified by using css Jun 4, 2021
@bsekachev bsekachev changed the title Some JS code was simplified by using css Some JS code was simplified by using css, a reported issue was fixed in this way Jun 4, 2021
@bsekachev
Copy link
Member Author

@dvkruchinin

Could you please prepare a test for this bug? I think if we already have tests that check sidebar collapsing or fullscreen, they could be updated instead of creating a new one.

@dvkruchinin
Copy link
Contributor

Could you please prepare a test for this bug? I think if we already have tests that check sidebar collapsing or fullscreen, they could be updated instead of creating a new one.

Sure. A tests will be prepared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fullscreen has bugs
3 participants