Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: "TypeError: Cannot read property 'clientX' of undefined" #3308

Merged
merged 10 commits into from
Jun 16, 2021

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Jun 9, 2021

Motivation and context

Resolved #3219
Resolved #2873

How has this been tested?

Manual testing

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bsekachev bsekachev added the bug Something isn't working label Jun 9, 2021
@bsekachev bsekachev requested a review from nmanovic June 9, 2021 11:52
@bsekachev
Copy link
Member Author

@dvkruchinin

Could you please update cypress tests with cuboids after PR is ready?

@dvkruchinin
Copy link
Contributor

Could you please update cypress tests with cuboids after PR is ready?

Sure. A tests will be updated.

@bsekachev bsekachev requested a review from azhavoro as a code owner June 9, 2021 15:03
@bsekachev bsekachev changed the title [WIP] Fixed: "TypeError: Cannot read property 'clientX' of undefined" Fixed: "TypeError: Cannot read property 'clientX' of undefined" Jun 10, 2021
@ActiveChooN
Copy link
Contributor

@bsekachev, there is one case when the issue still appears. Steps to reproduce:

  1. Draw a cuboid
  2. Start redrawing with Shift+N
  3. Try to finish redrawing with N
Computer.Vision.Annotation.Tool.-.Google.Chrome.2021-06-15.13-33-52.mp4

@bsekachev
Copy link
Member Author

@ActiveChooN
That was fixed.

@bsekachev bsekachev merged commit 957bc29 into develop Jun 16, 2021
@bsekachev bsekachev deleted the bs/fixed_issue_3219 branch June 17, 2021 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants