Extension of cloud storage server part #3386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
bsekachev
reviewed
Aug 12, 2021
cvat/apps/engine/views.py
Outdated
| specific_attributes = serializer.validated_data.get('specific_attributes', '') | ||
|
|
||
| check_cloud_storage_existing(provider_type, credentials_type, session_token, account_name, | ||
| key, secret_key, resource, specific_attributes) | ||
| owner = self.request.data.get('owner') | ||
| if owner: |
There was a problem hiding this comment.
Shall we consider owner to be a user who does not send the request? In theory I can create a storage and make owner a user who I do not know accidentally. This user might get access to private data.
Marishka17
force-pushed
the
mk/expansion_server_cloud_storage
branch
from
60f348a
to
070dbcf
Compare
Marishka17
changed the title
azhavoro
reviewed
Aug 16, 2021
| @@ -223,6 +223,9 @@ def load(self): | |||
| self._index = json.load(index_file, | |||
| object_hook=lambda d: {int(k): v for k, v in d.items()}) | |||
|
|
|||
| def remove(self): | |||
| os.remove(self._path) | |||
There was a problem hiding this comment.
shouldn't self.path be null or something like that after deleting?
There was a problem hiding this comment.
no, it shouldn't
Marishka17
changed the title
|
@azhavoro , @bsekachev What do you think about this? |
Marishka17
changed the title
Marishka17
force-pushed
the
mk/expansion_server_cloud_storage
branch
from
3eb6a81
to
c1f68a7
Compare
azhavoro
reviewed
Aug 30, 2021
| @@ -6,7 +6,7 @@ | |||
| class Migration(migrations.Migration): | |||
|
|
|||
| dependencies = [ | |||
| ('engine', '0040_cloud_storage'), | |||
| ('engine', '0041_auto_20210813_0853'), | |||
There was a problem hiding this comment.
Not sure if this is the right way, maybe reordering the migration is here. Please make sure this works if migration "0040" has already been applied.
|
@azhavoro, Do you have any other comments? |
|
@Marishka17 LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
This PR contains:
How has this been tested?
Checklist
developbranch- [ ] I have linked related issues (read github docs)- [ ] I have increased versions of npm packages if it is necessary (cvat-canvas,cvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.