Adding support for 16bit grayscale images for annotation #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e converting to RGB
Happyzippy
changed the title
nmanovic
reviewed
Mar 8, 2019
image autoscaling reformatted for easier readability along with comments
|
Hi @Happyzippy , codacy reports 2 issues. One of them is quite serious. Could you please fix both? |
|
Hi @Happyzippy , It seems the patch doesn't work. Could you please test it one more time? |
Traceback (most recent call last):
File "/usr/local/lib/python3.5/dist-packages/rq/worker.py", line 799, in perform_job
rv = job.perform()
File "/usr/local/lib/python3.5/dist-packages/rq/job.py", line 600, in perform
self._result = self._execute()
File "/usr/local/lib/python3.5/dist-packages/rq/job.py", line 606, in _execute
return self.func(*self.args, **self.kwargs)
File "/home/django/cvat/apps/engine/plugins.py", line 56, in function_wrapper
result = function_to_decorate(*args, **kwargs)
File "/usr/lib/python3.5/contextlib.py", line 30, in inner
return func(*args, **kwds)
File "/home/django/cvat/apps/engine/task.py", line 710, in _create_thread
task_params['compress'], task_params['flip'], job)
File "/home/django/cvat/apps/engine/task.py", line 587, in _find_and_compress_images
im_data *= 2**8 / im_data.max()
TypeError: Cannot cast ufunc multiply output from dtype('float64') to dtype('int32') with casting rule 'same_kind'
Add more commits by pushing to the develop branch on Happyzippy/cvat.
Review required
At least 1 approving review is required by reviewers with write access.
All checks have passed
3 successful checks
Codacy/PR Quality Review — Up to standards. A positive pull request.
Details
@wip
WIP Successful in 1s — Ready for review
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
Merging is blocked
Merging can be performed automatically with 1 approving review.
@Happyzippy
Attach files by dragging & dropping, selecting them, or pasting from the clipboard.
Styling with Markdown is supported
ProTip! Add .patch or .diff to the end of URLs for Git’s plaintext views.
|
Hi @nmanovic, Sorry for all the inconvenience |
nmanovic
approved these changes
Mar 18, 2019
|
Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for 16bit grayscale images for annotation