Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress. Fix case "Actions on polygon" for Firefox. #3446

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

dvkruchinin
Copy link
Contributor

Motivation and context

In CI nightly, the unsuccessful completion of the case 16 test. It is reproduced in Firefox browser in headless mode.
In the test, the shape is activated by pointing the cursor at it (mouse events). One of the steps of the shape activation test:
firefox_shape_activating
Activation is not performed.
In this patch, I just changed the activation method via sidebar item.

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bsekachev bsekachev self-assigned this Jul 21, 2021
@@ -70,7 +70,8 @@ context('Actions on polygon', () => {
});

it('Activate first shape', () => {
cy.get('#cvat_canvas_shape_1').trigger('mousemove').trigger('mouseover');
cy.get('#cvat-objects-sidebar-state-item-1').trigger('mousemove').trigger('mouseover');
Copy link
Member

@bsekachev bsekachev Jul 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the same issue in another test when was writing PR #3417 (test case_37_object_make_copy.js). It also was reproducible only in headless (but in Chrome). I changed the following:
Screenshot from 2021-07-22 00-35-23

And looks like it helped.
Maybe it helps you to understand the root cause (I didn't understand).

@bsekachev bsekachev merged commit f82dcae into cvat-ai:develop Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants