Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect comparison #3674

Merged
merged 3 commits into from
Sep 21, 2021
Merged

Fix incorrect comparison #3674

merged 3 commits into from
Sep 21, 2021

Conversation

Horstage
Copy link
Contributor

@Horstage Horstage commented Sep 15, 2021

Motivation and context

I have seen this error in the code and wanted to provide a fix. Doing so via GitHubs tools was the fastest way.

How has this been tested?

Not at all. I haven't even added a unit test for this.
This line of code was clearly intended the way I changed it.
I do understand however if you want me to properly test it, but this will take time.

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@azhavoro
Copy link
Contributor

@Horstage Thank you for your contribution!

@nmanovic
Copy link
Contributor

@Horstage , could you please merge the latest develop branch? I hope it will solve problems with tests.

@nmanovic
Copy link
Contributor

@dvkruchinin , could you please look at the issue? After the contributor merged 'develop', we still have failed tests. I'm sure UI tests should not be affected by the change.

@nmanovic nmanovic merged commit d91ba56 into cvat-ai:develop Sep 21, 2021
@dvkruchinin
Copy link
Contributor

After the contributor merged 'develop', we still have failed tests. I'm sure UI tests should not be affected by the change.

@nmanovic
I tried to solve this problem in #3693

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants