Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with getting cloud storages in Firefox #3733

Merged
merged 4 commits into from
Sep 27, 2021

Conversation

Marishka17
Copy link
Contributor

@Marishka17 Marishka17 commented Sep 27, 2021

Motivation and context

Resolve #3719

How has this been tested?

Manually

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@Marishka17 Marishka17 changed the title Fix problem with getting cloud storages in Firefox [WIP] Fix problem with getting cloud storages in Firefox Sep 27, 2021
@Marishka17 Marishka17 force-pushed the mk/fix_getting_cloud_storage_firefox branch from 935f4e5 to 33b8441 Compare September 27, 2021 08:39
@@ -20,7 +20,6 @@ onmessage = (e) => {
.catch((error) => {
postMessage({
id: e.data.id,
error: error,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was redundant information and resulted in an emergence of DataCloneError: The object could not be cloned

@Marishka17 Marishka17 changed the title [WIP] Fix problem with getting cloud storages in Firefox Fix problem with getting cloud storages in Firefox Sep 27, 2021
@bsekachev bsekachev merged commit ecee806 into develop Sep 27, 2021
@nmanovic nmanovic deleted the mk/fix_getting_cloud_storage_firefox branch September 28, 2021 07:02
@Marishka17
Copy link
Contributor Author

@dvkruchinin , Hi, Could you please prepare a test for this change? This problem is related not to the cloud storage feature. I understand, that for the cloud storage feature it is too hard to check this in a test, but there is one way to reproduce such behavior.
Need to create a task with share data (images), then e.g. remove an image and try to open an annotation task. In this case, a notification should appear.
It is actual for firefox.

@dvkruchinin
Copy link
Contributor

Need to create a task with share data (images), then e.g. remove an image and try to open an annotation task. In this case, a notification should appear. It is actual for firefox.

@Marishka17 Sure. I'll see what I can do. At the moment, there are no tests for creating a task using share data, as this may cause some difficulties when running in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with getting cloud storages in Firefox
3 participants