-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix problem with getting cloud storages in Firefox #3733
Conversation
935f4e5
to
33b8441
Compare
@@ -20,7 +20,6 @@ onmessage = (e) => { | |||
.catch((error) => { | |||
postMessage({ | |||
id: e.data.id, | |||
error: error, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was redundant information and resulted in an emergence of DataCloneError: The object could not be cloned
@dvkruchinin , Hi, Could you please prepare a test for this change? This problem is related not to the cloud storage feature. I understand, that for the cloud storage feature it is too hard to check this in a test, but there is one way to reproduce such behavior. |
@Marishka17 Sure. I'll see what I can do. At the moment, there are no tests for creating a task using share data, as this may cause some difficulties when running in CI. |
Motivation and context
Resolve #3719
How has this been tested?
Manually
Checklist
develop
branch- [ ] I have updated the documentation accordingly- [ ] I have added tests to cover my changescvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.