Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LFW format #3770

Merged
merged 9 commits into from
Nov 9, 2021
Merged

Add LFW format #3770

merged 9 commits into from
Nov 9, 2021

Conversation

sizov-kirill
Copy link
Contributor

@sizov-kirill sizov-kirill commented Oct 6, 2021

Motivation and context

Added LFW format.

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@sizov-kirill sizov-kirill changed the title Add LFW format [WIP] Add LFW format Oct 6, 2021
@zhiltsov-max
Copy link
Contributor

Will you add the format documentation file in Datumaro?

@sizov-kirill
Copy link
Contributor Author

Will you add the format documentation file in Datumaro?

Yes, I'll add

@sizov-kirill sizov-kirill changed the title [WIP] Add LFW format Add LFW format Nov 3, 2021
zhiltsov-max
zhiltsov-max previously approved these changes Nov 8, 2021
└── annotations/
├── landmarks.txt # list with landmark points for each image
├── pairs.txt # list of matched and mismatched pairs of person
└── people.txt # list of persons name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the file optional now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's. Added clarification about it.

@nmanovic
Copy link
Contributor

nmanovic commented Nov 9, 2021

The main question for me now: should we allow to export tasks in the format, if they don't correspond to the expected format. For example, our tasks don't have corresponding attributes. I have created a task with pets (cat, dog) without necessary attributes and exported the dataset in LFW. Did I get something useful?

@sizov-kirill
Copy link
Contributor Author

The main question for me now: should we allow to export tasks in the format, if they don't correspond to the expected format. For example, our tasks don't have corresponding attributes. I have created a task with pets (cat, dog) without necessary attributes and exported the dataset in LFW. Did I get something useful?

@nmanovic I think, without attributes this format can still be useful for image/face classification task.

@nmanovic nmanovic merged commit cc801b2 into develop Nov 9, 2021
@nmanovic nmanovic deleted the sk/add-lfw branch November 9, 2021 12:15
@nmanovic nmanovic mentioned this pull request Mar 4, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants