Remove key_file_path field #3959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmanovic
previously approved these changes
Dec 1, 2021
bsekachev
reviewed
Dec 1, 2021
| multiple={false} | ||
| maxCount={1} | ||
| fileList={ | ||
| uploadedKeyFile ? [{ uid: '1', name: 'key.json' }] : [] |
There was a problem hiding this comment.
Why do you show unreal file name?
There was a problem hiding this comment.
Because in this case we control output and avoid a situation like this:
cvat-ui/src/components/create-cloud-storage-page/cloud-storage-form.tsx
Outdated
Show resolved
Hide resolved
bsekachev
approved these changes
Dec 1, 2021
|
@dvkruchinin , Could you please also prepare a test for Google Cloud Storage? |
|
@TOsmanov, Could you please prepare the documentation for Google Cloud Storage? |
@Marishka17, Yes, sure |
@Marishka17 Sure. A test will be prepared. |
8 tasks
sarikaya
added a commit
to roboduels/cvat
that referenced
this pull request
Dec 4, 2021
…o openvinotoolkit-develop * 'develop' of https://github.com/openvinotoolkit/cvat: (181 commits) Cypress. Update case 105. Add check "Google cloud storage" provider fields. (cvat-ai#3980) Cypress. Fix case 108 for Firefox. (cvat-ai#3981) update project section (cvat-ai#3979) Cypress. Test "Rotated bounding boxes" (cvat-ai#3961) Issue deleting (cvat-ai#3952) Remove key_file_path field (cvat-ai#3959) update the doc for change default hostname or port (cvat-ai#3915) CVAT_server. Test for "Project updated time". (cvat-ai#3953) fix: cvat/requirements/base.txt to reduce vulnerabilities (cvat-ai#3970) Fix notification (cvat-ai#3960) Update documentation for China users (cvat-ai#3946) Support GCS (cvat-ai#3919) Cypress. Update the test for check issue 3810. (cvat-ai#3900) Update the documentation about the smooth image option (cvat-ai#3947) Project tasks pagination (cvat-ai#3910) Update documentation about review mode (cvat-ai#3944) Preserve the order of the label attributes in the object item details. (cvat-ai#3945) Added smooth image option (cvat-ai#3933) Fixed issue: autoborder points are visible for invisible shapes (cvat-ai#3931) Add FiftyOne to partners list (cvat-ai#3943) ...
sarikaya
added a commit
to roboduels/cvat
that referenced
this pull request
Dec 4, 2021
* openvinotoolkit-develop: (181 commits) Cypress. Update case 105. Add check "Google cloud storage" provider fields. (cvat-ai#3980) Cypress. Fix case 108 for Firefox. (cvat-ai#3981) update project section (cvat-ai#3979) Cypress. Test "Rotated bounding boxes" (cvat-ai#3961) Issue deleting (cvat-ai#3952) Remove key_file_path field (cvat-ai#3959) update the doc for change default hostname or port (cvat-ai#3915) CVAT_server. Test for "Project updated time". (cvat-ai#3953) fix: cvat/requirements/base.txt to reduce vulnerabilities (cvat-ai#3970) Fix notification (cvat-ai#3960) Update documentation for China users (cvat-ai#3946) Support GCS (cvat-ai#3919) Cypress. Update the test for check issue 3810. (cvat-ai#3900) Update the documentation about the smooth image option (cvat-ai#3947) Project tasks pagination (cvat-ai#3910) Update documentation about review mode (cvat-ai#3944) Preserve the order of the label attributes in the object item details. (cvat-ai#3945) Added smooth image option (cvat-ai#3933) Fixed issue: autoborder points are visible for invisible shapes (cvat-ai#3931) Add FiftyOne to partners list (cvat-ai#3943) ...
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
#3919 (comment)
How has this been tested?
Manually
Checklist
developbranch- [ ] I have updated the documentation accordingly- [ ] I have linked related issues (read github docs)cvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
- [ ] I have updated the license header for each file (see an example below)