Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added options to switch text font size and position #3972

Merged
merged 11 commits into from
Dec 5, 2021

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Dec 1, 2021

Motivation and context

image

Default behaviour:
image

Updated behaviour:
image

Polylabel algorithm is used to find best place for text (https://blog.mapbox.com/a-new-algorithm-for-finding-a-visual-center-of-a-polygon-7c77e6492fbc)

How has this been tested?

Checklist

Resolved #1107

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bsekachev bsekachev added the enhancement New feature or request label Dec 1, 2021
@bsekachev
Copy link
Member Author

Hi, @nstolyarov

Could you please look at this PR and say us if this is a thing could help you, or maybe suggest other ideas?

@bsekachev bsekachev changed the title [WIP] Added options to switch text font size and position Added options to switch text font size and position Dec 2, 2021
Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I believe the polylabel is a great solution for the problem.

@nmanovic nmanovic merged commit ab351c2 into develop Dec 5, 2021
@nmanovic nmanovic deleted the bs/added_text_options branch December 5, 2021 10:15
@bsekachev
Copy link
Member Author

@aschernov @TOsmanov

Guys, could you please update documentation according to these new features?

@bsekachev
Copy link
Member Author

@dvkruchinin Could you please prepare a test? At least font-size should be tested. I am not sure about good approach to test position, but if you have any ideas how it could be implemented, it is great

@TOsmanov
Copy link
Contributor

TOsmanov commented Dec 6, 2021

@aschernov @TOsmanov

Guys, could you please update documentation according to these new features?

@bsekachev Yes, sure

@dvkruchinin
Copy link
Contributor

@dvkruchinin Could you please prepare a test? At least font-size should be tested. I am not sure about good approach to test position, but if you have any ideas how it could be implemented, it is great

@bsekachev Sure. A test will be prepared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to increase the attributes text size
5 participants