Fix order #4087
Merged
Fix order #4087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you check these lines? If the results are in the reversed order, it looks like the |
| self.db_task = models.Task.objects.prefetch_related("data__images").get(id=pk) | ||
| self.db_task = models.Task.objects.prefetch_related( | ||
| Prefetch('data__images', queryset=models.Image.objects.order_by('frame')) | ||
| ).get(id=pk) | ||
|
|
||
| # Postgres doesn't guarantee an order by default without explicit order_by |
There was a problem hiding this comment.
It seems this comment also applies to the current fix.
zhiltsov-max
previously approved these changes
Dec 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Resolve #4025
How has this been tested?
Manually
Checklist
developbranch- [ ] I have updated the documentation accordingly- [ ] I have added tests to cover my changes- [ ] I have increased versions of npm packages if it is necessary (cvat-canvas,cvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.