Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Issues disappear when using a zoom #4189

Merged
merged 4 commits into from
Jan 19, 2022
Merged

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Jan 17, 2022

Motivation and context

Resolved #3975

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2022 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bsekachev bsekachev added the bug Something isn't working label Jan 17, 2022
@bsekachev bsekachev changed the title [WIP] Fixed: Issues disappear when using a zoom Fixed: Issues disappear when using a zoom Jan 17, 2022
@bsekachev
Copy link
Member Author

@ActiveChooN Could you please look at this patch?

@ActiveChooN
Copy link
Contributor

Looks good, but is it possible to prevent moving lines from the issue pattern when the browser window is resizing?
issue-window-resize-issue1

@ActiveChooN ActiveChooN linked an issue Jan 18, 2022 that may be closed by this pull request
2 tasks
@bsekachev
Copy link
Member Author

Looks good, but is it possible to prevent moving lines from the issue pattern when the browser window is resizing? issue-window-resize-issue1

I looked at API, tried some options and finally I am not sure we can control this effect.
Taking into account the fact, that it is not a user scenario and it actually does not bring any issues for the user, let's keep as is.

@ActiveChooN
Copy link
Contributor

Looks good, but is it possible to prevent moving lines from the issue pattern when the browser window is resizing? issue-window-resize-issue1

I looked at API, tried some options and finally I am not sure we can control this effect. Taking into account the fact, that it is not a user scenario and it actually does not bring any issues for the user, let's keep as is.

Sure.

@bsekachev bsekachev merged commit d3db54d into develop Jan 19, 2022
@nmanovic nmanovic deleted the bs/fixed_issue_3975_ branch January 19, 2022 18:25
@bsekachev
Copy link
Member Author

Hi, @dvkruchinin Do you think we can test this case?

@dvkruchinin
Copy link
Contributor

Hi, @dvkruchinin Do you think we can test this case?

Hi @bsekachev,
I think it's possible. I'll try.

bsekachev added a commit that referenced this pull request Feb 2, 2022
nmanovic pushed a commit that referenced this pull request Feb 3, 2022
* Implemented test for issue #3975 PR #4189
@nmanovic nmanovic mentioned this pull request Mar 4, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue region jumps when window resizes Issues disappear when using a zoom
3 participants