Deleted frames

[ActiveChooN]

Resolve #4235
Resolve #3000

Motivation and context

How has this been tested?

Checklist

• I submit my changes into the develop branch
• I have added a description of my changes into CHANGELOG file
  - [ ] I have updated the documentation accordingly
• I have added tests to cover my changes
• I have linked related issues (read github docs)
• I have increased versions of npm packages if it is necessary (cvat-canvas,
  cvat-core, cvat-data and cvat-ui)

License

• I submit my code changes under the same MIT License that covers the project.
  Feel free to contact the maintainers if that's a concern.
• I have updated the license header for each file (see an example below)

# Copyright (C) 2022 Intel Corporation
#
# SPDX-License-Identifier: MIT

[ActiveChooN]

@nmanovic

Also I don't like that we move to the next image automatically. Need to think twice about the behaviors.

Moving to the next frame is only working if the "Show deleted frames" option is disabled.

[nmanovic]

@ActiveChooN , automatic annotation is running on all frames, even deleted.

[nmanovic]

@ActiveChooN , could you please check tests? Are they hanging?

[nmanovic]

@ActiveChooN , if I delete a frame with annotations and after that restore it, I still can see annotations. But if I go to the next frame and return back, it is disappeared. Could you please check?

[nmanovic]

@ActiveChooN , I see some strange artifacts for trash bin. Is it a standard picture?

[nmanovic]

@ActiveChooN , do we have any shortcuts to delete a frame quickly? For now it is necessary for every deleted frame click twice using mouse. I will have two shortcuts with and without confirmation and show them in hints.

[nmanovic]

@ActiveChooN , don't like that in meta information we have a separate array for deleted frames. Do you see any ways to have "is_deleted" attribute as a part of information about a frame?

[nmanovic]

@ActiveChooN , why do we have a warning when we delete a frame without annotation but don't have a warning when we restore the frame?

[nmanovic]

@ActiveChooN , found a problem with tracks. Let's draw a track with key frames on 0, 10, 20 frames. If you delete the frame 0, the track will be removed completely. It tells me that the idea to delete annotations could be wrong and dangerous. Need to think one more time about that. Only in CVAT format we dump key frames only. It looks like it is the main problem.

[ActiveChooN]

@nmanovic,

@ActiveChooN , don't like that in meta information we have a separate array for deleted frames. Do you see any ways to have "is_deleted" attribute as a part of information about a frame?

We have video meta without object per frame information, so is_deleted key is not applicable in that case.

@ActiveChooN , I see some strange artifacts for trash bin. Is it a standard picture?

It's the default delete icon in antd, fixed it manually.

[violino22]

"It will be possible to mark a frame as deleted after the PR is merged"
What is "PR is merged"?

[nmanovic]

The pull request (PR) should be merged into develop branch and after that we should publish a release.

[violino22]

Запрос на включение (PR) должен быть объединен с веткой разработки, после чего мы должны опубликовать релиз.

Я просто наёмный работник)))
Я не хочу заморачиваться. Я просто хочу клацать на кнопочки, чтоб удалялись ненужные файлы из задачи, это возможно?)))

[nmanovic]

Yes, I understand that. In this case just wait. I hope in next release the feature should be available.

[FrankUSC]

@nmanovic
This is a very useful feature, do we have an ETA when will it be released?
Thank you!

[nmanovic]

@FrankUSC , it will be release this month.

[bsekachev]

The pull request has been finished and merged in our current fork, here: https://github.com/cvat-ai/cvat