Filtering for sandbox #4216
Merged
Filtering for sandbox #4216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 20, 2022 16:44
Now we have 3 types of visibility (aka org_filter) 1. org=slug - see objects only for the organization 2. org= - see objects only for sandbox (organzation is None) 3. None - see all objects which you can access
nmanovic
requested review from
sizov-kirill
and removed request for
bsekachev
|
@kirill-sizov , could you please look at the PR? It will be interesting to run your new tests as well. |
Yes, sure. |
bsekachev
approved these changes
Jan 23, 2022
sizov-kirill
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
There 3 modes for IAM:
org=slugonly corresponding objects for the organization are visibleorg=only objects outside an organization are visibleNoneall own or assigned objects are visible (admin can see all objects)How has this been tested?
Manually
Checklist
developbranch- [ ] I have added a description of my changes into CHANGELOG file- [ ] I have updated the documentation accordingly- [ ] I have added tests to cover my changes- [ ] I have linked related issues (read github docs)- [ ] I have increased versions of npm packages if it is necessary (cvat-canvas,cvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.