Some icons improvements #4286
Some icons improvements #4286
Conversation
|
@bsekachev , I guess
|
|
We should be consistent with other pages: There are not any color icons on other pages. What is special reason to have color here? |
|
@bsekachev, I only mean that it looks better. It's up to you. |
cvat-ui/src/components/cloud-storages-page/empty-cloud-storages-list.tsx
Show resolved
Hide resolved
| @@ -42,7 +42,7 @@ export default function ConstructorViewerItem(props: ConstructorViewerItemProps) | |||
| onClick={(): void => onDelete(label)} | |||
| onKeyPress={(): boolean => false} | |||
| > | |||
| <CloseOutlined /> | |||
| <MinusCircleOutlined /> | |||
There was a problem hiding this comment.
It looks quite strange, guess the close icon looked more convenient and less distracting.
There was a problem hiding this comment.
Add label: circled plus icon
Remove label: close icon
They are opposite actions, but icons not. One circled, another not. The same for attributes.
Following from the name of CloseOutlined it is even not supposed that the icon is used to remove something
There was a problem hiding this comment.
But I undestand you feeling about distracting, changed icon attract your attention for now because you are not used to it yet
There was a problem hiding this comment.
@bsekachev , which software or products use circle with minus to remove something?
There was a problem hiding this comment.
Figma:
Different options are possible: minus, trash icon, close icon. But in this specific case, I believe the best two are minus (like a pair for plus icon) and trash icon (looks well with edit icon and also very intuitive))
There was a problem hiding this comment.
IMHO: Cross and trash bin look better. Minus in a circle looks like the stop sign. On Figma icons without circle and they are in one column. It makes them clear semantically.
There was a problem hiding this comment.
Let's use trash instead, I am ok with it.
| @@ -329,7 +329,7 @@ export default class LabelForm extends React.Component<Props> { | |||
| this.removeAttribute(key); | |||
| }} | |||
| > | |||
| <CloseCircleOutlined /> | |||
| <MinusCircleOutlined /> | |||
…ere is the same antd icon)
Motivation and context
To clean up icons, improve UX
in context when meaning is removing something from a list, because opposite action has PlusCircleOutlined iconDiscussed below )How has this been tested?
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.