Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coninue from frame N, advanced user selector on jobs page #4297

Merged
merged 4 commits into from
Feb 9, 2022

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Feb 7, 2022

Motivation and context

image
image

How has this been tested?

Manual testing

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2022 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bsekachev bsekachev added the enhancement New feature or request label Feb 7, 2022
@bsekachev bsekachev changed the title [WIP] Coninue from frame N, advanced user selector on jobs page Coninue from frame N, advanced user selector on jobs page Feb 7, 2022
@bsekachev bsekachev requested review from ActiveChooN and klakhov and removed request for ActiveChooN February 7, 2022 12:31
@bsekachev
Copy link
Member Author

@klakhov

Could you please review the patch?

Copy link
Contributor

@klakhov klakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsekachev Nice feature! Have you thought about adding a setting (a default-enabled checkbox for example) that can enable/disable 'continue from' notification, probably someone who don't need it would find it annoying.

@bsekachev
Copy link
Member Author

@bsekachev Nice feature! Have you thought about adding a setting (a default-enabled checkbox for example) that can enable/disable 'continue from' notification, probably someone who don't need it would find it annoying.

Let's wait for such reports.

@nmanovic
Copy link
Contributor

nmanovic commented Feb 7, 2022

@bsekachev , what I really like in notifications, it is easy way to disable them. But probably it is another feature. It should be done not only for the notification.

@bsekachev bsekachev merged commit 696e51f into develop Feb 9, 2022
@bsekachev bsekachev deleted the bs/continue_frame branch February 9, 2022 11:06
@bsekachev
Copy link
Member Author

@TOsmanov

Could you please update documentation about continue working from frame N?
Jobs page related documentation can be omitted for now, because it will be significantly updated soon/

@TOsmanov
Copy link
Contributor

TOsmanov commented Feb 9, 2022

@TOsmanov

Could you please update documentation about continue working from frame N? Jobs page related documentation can be omitted for now, because it will be significantly updated soon/

@bsekachev , yes, I will update the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants